<table><tr><td style="">schwarzer added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D9790" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>Thanks for picking up the topic with a patch. :)<br />
I might be able to test this tonight but not sure.<br />
Anyway, here are just some things I saw while scrolling over the patch.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D9790#inline-44418" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">logic.js:38</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #74777d">// Substeps are used to avoid that the ball is moved too far in a single update,</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #74777d">// possibly leading to buggy behavior. The movement is diveded into multiple</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #74777d">// substeps and collisions are detected after each substep.</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">divided</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D9790#inline-44420" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">logic.js:435</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">        <span style="color: #aa4000">if</span> <span class="p">(<span class="bright"></span></span><span class="bright"></span><span style="color: #004012"><span class="bright">gameTimer</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">interval</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">>=</span></span><span class="bright"> </span><span style="color: #004012"><span class="bright">Globals</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">REPAINT_INTERVAL</span></span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">            <span class="bright"></span><span style="color: #aa4000"><span class="bright">if</span></span><span class="bright"> </span><span class="p"><span class="bright">(</span></span><span style="color: #004012">speed</span> <span class="bright"></span><span style="color: #aa2211"><span class="bright"><</span></span> <span style="color: #004012">Globals</span><span class="p">.</span><span style="color: #004012">MINIMUM_SPEED<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span><span class="bright"> </span><span class="p"><span class="bright">{</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">                <span style="color: #004012">speed</span> <span style="color: #aa2211">=</span> <span style="color: #004012">Globals</span><span class="p">.</span><span style="color: #004012">MINIMUM_SPEED</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">            <span class="p">}</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #aa4000">if</span> <span class="p">(<span class="bright"></span></span><span class="bright"></span><span style="color: #004012"><span class="bright">substeps</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">==</span></span><span class="bright"> </span><span style="color: #601200"><span class="bright">1</span></span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span style="color: #004012">speed</span> <span class="bright"></span><span style="color: #aa2211"><span class="bright">=</span></span> <span style="color: #004012">Globals</span><span class="p">.</span><span style="color: #004012">MINIMUM_SPEED<span class="bright"></span></span><span class="bright"> </span><span style="color: #74777d"><span class="bright">// minimum speed</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; ">            <span style="color: #aa4000">return</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I don't think this comment is necessary. :)</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R393 KBreakout</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D9790" rel="noreferrer">https://phabricator.kde.org/D9790</a></div></div><br /><div><strong>To: </strong>helfferich, KDE Games<br /><strong>Cc: </strong>schwarzer, KDE Games<br /></div>