<table><tr><td style="">ouwerkerk requested changes to this revision.<br />ouwerkerk added a comment.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D5627" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>I've added a few more comments. Before landing this change please review the one on copyright in particular, as I'm not certain the way a few copyright statements were consolidated is sound (or rather that the implications are what was intended).</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D5627#inline-23004" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ksudoku.cpp:5</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa2211">*</span> <span class="n">Copyright</span> <span style="color: #601200">2006</span><span style="color: #aa2211">-</span><span style="color: #601200">2008</span> <span class="n">Johannes</span> <span class="n">Bergmeier</span> <span style="color: #aa2211"><</span><span class="n">johannes</span><span class="p">.</span><span class="n">bergmeier</span><span class="err">@</span><span class="n">gmx</span><span class="p">.</span><span class="n">net</span><span style="color: #aa2211">></span> <span style="color: #aa2211">*</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa2211">*</span> <span class="n">Copyright</span> <span style="color: #601200">2012<span class="bright"></span></span><span class="bright"> </span> <span class="n">Ian</span> <span class="n">Wadham</span> <span style="color: #aa2211"><</span><span class="n">iandw</span><span class="p">.</span><span class="n">au</span><span class="err">@</span><span class="n">gmail</span><span class="p">.</span><span class="n">com</span><span style="color: #aa2211">></span> <span style="color: #aa2211">*</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa2211">*</span> <span class="n">Copyright</span> <span style="color: #601200">2015</span> <span class="n">Ian</span> <span class="n">Wadham</span> <span style="color: #aa2211"><</span><span class="n">iandw</span><span class="p">.</span><span class="n">au</span><span class="err">@</span><span class="n">gmail</span><span class="p">.</span><span class="n">com</span><span style="color: #aa2211">></span> <span style="color: #aa2211">*</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa2211">*</span> <span class="n">Copyright</span> <span style="color: #601200">2012<span class="bright"></span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">-</span></span><span class="bright"></span><span style="color: #601200"><span class="bright">2015</span></span> <span class="n">Ian</span> <span class="n">Wadham</span> <span style="color: #aa2211"><</span><span class="n">iandw</span><span class="p">.</span><span class="n">au</span><span class="err">@</span><span class="n">gmail</span><span class="p">.</span><span class="n">com</span><span style="color: #aa2211">></span> <span style="color: #aa2211">*</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa2211">*</span> <span style="color: #aa2211">*</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This change may not be sound:</p>
<p style="padding: 0; margin: 8px;">As I understand it:</p>
<ul class="remarkup-list">
<li class="remarkup-list-item">Copyright 2012 means copyright on the work for the year 2012</li>
<li class="remarkup-list-item">Copyright 2012, 2015 means copyright on the work for the years 2012 and 2015.</li>
<li class="remarkup-list-item">Copyright 2012-2015 means copyright on the work for the years 2012 thru 2015 (inclusive), i.e. 2012, 2013, 2014 and 2015.</li>
</ul>
<p style="padding: 0; margin: 8px;">Since the previous version did not claim copyright over 2013-2014, perhaps we should either leave both lines as is or maybe consolidate using <tt style="background: #ebebeb; font-size: 13px;">Copyright 2012, 2015</tt> instead?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D5627#inline-22985" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">stikonas</span> wrote in <span style="color: #4b4d51; font-weight: bold;">serializer.cpp:402</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">Maybe do refactoring in a separate patch? This needs to fix calls to these functions too then... But yeah, that sounds good.</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Agreed.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D5627#inline-23006" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">serializer.cpp:472</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="p">}</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">success</span> <span style="color: #aa2211">=</span> <span style="color: #304a96">true</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Maybe I'm losing track here, but I think <tt style="background: #ebebeb; font-size: 13px;">success</tt> is no longer relevant? Because the code now short-circuits by returning early, we only get here on success. The following <tt style="background: #ebebeb; font-size: 13px;">if()</tt> check has therefore become redundant as well.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R417 KSudoku</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D5627" rel="noreferrer">https://phabricator.kde.org/D5627</a></div></div><br /><div><strong>To: </strong>stikonas, KDE Games, ltoscano, ouwerkerk<br /></div>