<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/130095/">https://git.reviewboard.kde.org/r/130095/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been discarded.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Games, Luigi Toscano and Frederik Schwarzer.</div>
<div>By Nemanja Hirsl.</div>
<p style="color: grey;"><i>Updated April 22, 2017, 10:39 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ksirk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">[Ksirk frameworks] Remove KDELibs4Support</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Didn't test Jabber funcionality, although some changes were made there.</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Game play works.</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">KDE New Stuff doesn't work neither in frameworks nor master. Has to be fixed.</li>
</ul></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(54910ed)</span></li>
<li>ksirk/CMakeLists.txt <span style="color: grey">(260da6a)</span></li>
<li>ksirk/Dialogs/InvasionSlider.cpp <span style="color: grey">(041992f)</span></li>
<li>ksirk/Dialogs/jabbergameui.cpp <span style="color: grey">(dd0e9a0)</span></li>
<li>ksirk/Dialogs/joingame.cpp <span style="color: grey">(c00c88a)</span></li>
<li>ksirk/Dialogs/kplayersetupwidget.cpp <span style="color: grey">(b55e170)</span></li>
<li>ksirk/Dialogs/kwaitedplayersetupdialog.cpp <span style="color: grey">(a51509e)</span></li>
<li>ksirk/Dialogs/newGameDialog.ui <span style="color: grey">(1b30a53)</span></li>
<li>ksirk/Dialogs/newGameDialogImpl.cpp <span style="color: grey">(80c8717)</span></li>
<li>ksirk/Dialogs/newGameSummaryWidget.cpp <span style="color: grey">(8031cc9)</span></li>
<li>ksirk/Dialogs/qplayersetupdialog.ui <span style="color: grey">(430dee5)</span></li>
<li>ksirk/Dialogs/restartOrExitDialogImpl.cpp <span style="color: grey">(aad96f9)</span></li>
<li>ksirk/Dialogs/tcpconnectwidget.cpp <span style="color: grey">(c3cf605)</span></li>
<li>ksirk/Dialogs/tcpconnectwidget.ui <span style="color: grey">(f343310)</span></li>
<li>ksirk/GameLogic/KsirkChatDelegate.cpp <span style="color: grey">(dbbbd0b)</span></li>
<li>ksirk/GameLogic/KsirkChatItem.cpp <span style="color: grey">(2d079dd)</span></li>
<li>ksirk/GameLogic/KsirkChatModel.cpp <span style="color: grey">(1e3cd03)</span></li>
<li>ksirk/GameLogic/aiColsonPlayer.cpp <span style="color: grey">(19829fb)</span></li>
<li>ksirk/GameLogic/aiplayer.cpp <span style="color: grey">(50c9757)</span></li>
<li>ksirk/GameLogic/continent.cpp <span style="color: grey">(b97713a)</span></li>
<li>ksirk/GameLogic/country.cpp <span style="color: grey">(eae46c9)</span></li>
<li>ksirk/GameLogic/dice.h <span style="color: grey">(2ff2e6d)</span></li>
<li>ksirk/GameLogic/eventslistproperty.cpp <span style="color: grey">(9553514)</span></li>
<li>ksirk/GameLogic/gameautomaton.h <span style="color: grey">(f55f649)</span></li>
<li>ksirk/GameLogic/gameautomaton.cpp <span style="color: grey">(ba41d50)</span></li>
<li>ksirk/GameLogic/goal.cpp <span style="color: grey">(b4a515e)</span></li>
<li>ksirk/GameLogic/onu.cpp <span style="color: grey">(30a9d9c)</span></li>
<li>ksirk/GameLogic/player.cpp <span style="color: grey">(8bc8384)</span></li>
<li>ksirk/Jabber/jabberbytestream.cpp <span style="color: grey">(39ce88f)</span></li>
<li>ksirk/Jabber/jabberclient.cpp <span style="color: grey">(ca5e9f5)</span></li>
<li>ksirk/Jabber/jabberconnector.cpp <span style="color: grey">(a41b384)</span></li>
<li>ksirk/Jabber/kmessagejabber.cpp <span style="color: grey">(cdd1b5d)</span></li>
<li>ksirk/Jabber/privacylist.cpp <span style="color: grey">(67f9139)</span></li>
<li>ksirk/Jabber/privacylistitem.cpp <span style="color: grey">(40f7569)</span></li>
<li>ksirk/Jabber/privacymanager.cpp <span style="color: grey">(02b2f4d)</span></li>
<li>ksirk/SaveLoad/ksirkgamexmlhandler.cpp <span style="color: grey">(209d595)</span></li>
<li>ksirk/Sprites/animsprite.cpp <span style="color: grey">(3b2c982)</span></li>
<li>ksirk/Sprites/animspritesgroup.cpp <span style="color: grey">(1adb2a0)</span></li>
<li>ksirk/Sprites/animspriteslist.h <span style="color: grey">(8084ce5)</span></li>
<li>ksirk/Sprites/animspritespool.cpp <span style="color: grey">(5fceca5)</span></li>
<li>ksirk/Sprites/arrowsprite.cpp <span style="color: grey">(7e7646b)</span></li>
<li>ksirk/Sprites/backgnd.h <span style="color: grey">(8633303)</span></li>
<li>ksirk/Sprites/backgnd.cpp <span style="color: grey">(736fc30)</span></li>
<li>ksirk/Sprites/cannonsprite.cpp <span style="color: grey">(3e99d3c)</span></li>
<li>ksirk/decoratedgameframe.cpp <span style="color: grey">(028e435)</span></li>
<li>ksirk/fightArena.h <span style="color: grey">(16312fe)</span></li>
<li>ksirk/fightArena.cpp <span style="color: grey">(de17ee1)</span></li>
<li>ksirk/gestionSprites.cpp <span style="color: grey">(90a3fb9)</span></li>
<li>ksirk/iris/src/irisnet/corelib/objectsession.cpp <span style="color: grey">(03b4f74)</span></li>
<li>ksirk/iris/src/xmpp/base64/base64.cpp <span style="color: grey">(3e2023d)</span></li>
<li>ksirk/iris/src/xmpp/cutestuff/httpconnect.cpp <span style="color: grey">(204c274)</span></li>
<li>ksirk/iris/src/xmpp/cutestuff/httppoll.cpp <span style="color: grey">(4e05ba9)</span></li>
<li>ksirk/iris/src/xmpp/xmpp-im/xmpp_vcard.cpp <span style="color: grey">(cdbd49b)</span></li>
<li>ksirk/iris/src/xmpp/xmpp-im/xmpp_xmlcommon.cpp <span style="color: grey">(29e4e1f)</span></li>
<li>ksirk/kgamewin.h <span style="color: grey">(b3dadb7)</span></li>
<li>ksirk/kgamewin.cpp <span style="color: grey">(50795e0)</span></li>
<li>ksirk/kgamewinslots.cpp <span style="color: grey">(cb5d210)</span></li>
<li>ksirk/krightdialog.h <span style="color: grey">(c3da2b7)</span></li>
<li>ksirk/krightdialog.cpp <span style="color: grey">(8f0095c)</span></li>
<li>ksirk/ksirkConfigDialog.cpp <span style="color: grey">(c84b181)</span></li>
<li>ksirk/mainMenu.cpp <span style="color: grey">(935617b)</span></li>
<li>ksirk/newgamesetup.cpp <span style="color: grey">(6384c09)</span></li>
<li>ksirkskineditor/CMakeLists.txt <span style="color: grey">(ecf2d78)</span></li>
<li>ksirkskineditor/ksirkSkinEditorConfigDialog.cpp <span style="color: grey">(bf00a82)</span></li>
<li>ksirkskineditor/ksirkcontinentdefinition.ui <span style="color: grey">(76053f3)</span></li>
<li>ksirkskineditor/ksirkcountrydefinition.ui <span style="color: grey">(e7a2f68)</span></li>
<li>ksirkskineditor/ksirkskindefinition.ui <span style="color: grey">(54eee30)</span></li>
<li>ksirkskineditor/ksirkspritesdefinition.ui <span style="color: grey">(ca97e28)</span></li>
<li>ksirkskineditor/mainwindow.h <span style="color: grey">(c778c60)</span></li>
<li>ksirkskineditor/mainwindow.cpp <span style="color: grey">(e876b84)</span></li>
<li>ksirkskineditor/onu.h <span style="color: grey">(3af5a3c)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/130095/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>