<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/130102/">https://git.reviewboard.kde.org/r/130102/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 22nd, 2017, 11:05 p.m. UTC, <b>Luigi Toscano</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/130102/diff/1/?file=495219#file495219line388" style="color: black; font-weight: bold; text-decoration: underline;">ksirk/gestionSprites.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">386</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">qreal</span> <span class="n">pointDepartAttaquantX</span><span class="p">;</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">386</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="hl"> </span><span class="c1"><span class="hl">//</span>qreal pointDepartAttaquantX;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">unrelated change?</p></pre>
</blockquote>
<p>On April 22nd, 2017, 11:21 p.m. UTC, <b>Nemanja Hirsl</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Yes, fix warnings.</p></pre>
</blockquote>
<p>On April 22nd, 2017, 11:36 p.m. UTC, <b>Luigi Toscano</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">if the variable it's not used at all, remove it.</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I would like to keep it as it is assigned in some calculations, but not used later.
If there is a bug behind it, it would be easier to spot it in the code as commented out section than looking in the history.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It is for all the commented parts here.</p></pre>
<br />
<p>- Nemanja</p>
<br />
<p>On April 22nd, 2017, 10:57 p.m. UTC, Nemanja Hirsl wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Games.</div>
<div>By Nemanja Hirsl.</div>
<p style="color: grey;"><i>Updated April 22, 2017, 10:57 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ksirk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">[Ksirk frameworks] Remove dependency on KDELibs4Support</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Gameplay.
Network game was not tested</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(1eff2fe)</span></li>
<li>ksirk/CMakeLists.txt <span style="color: grey">(4448f77)</span></li>
<li>ksirk/Dialogs/InvasionSlider.cpp <span style="color: grey">(b74c55c)</span></li>
<li>ksirk/Dialogs/jabbergameui.cpp <span style="color: grey">(0cca7bc)</span></li>
<li>ksirk/Dialogs/newGameDialog.ui <span style="color: grey">(1b30a53)</span></li>
<li>ksirk/Dialogs/newGameDialogImpl.cpp <span style="color: grey">(d091ac1)</span></li>
<li>ksirk/Dialogs/newGameSummaryWidget.cpp <span style="color: grey">(e911145)</span></li>
<li>ksirk/Dialogs/qplayersetupdialog.ui <span style="color: grey">(430dee5)</span></li>
<li>ksirk/Dialogs/tcpconnectwidget.ui <span style="color: grey">(f343310)</span></li>
<li>ksirk/GameLogic/aiColsonPlayer.cpp <span style="color: grey">(a286678)</span></li>
<li>ksirk/GameLogic/country.cpp <span style="color: grey">(8d84368)</span></li>
<li>ksirk/GameLogic/dice.h <span style="color: grey">(2ff2e6d)</span></li>
<li>ksirk/GameLogic/gameautomaton.h <span style="color: grey">(f55f649)</span></li>
<li>ksirk/GameLogic/gameautomaton.cpp <span style="color: grey">(25d4ee6)</span></li>
<li>ksirk/GameLogic/onu.cpp <span style="color: grey">(838b89b)</span></li>
<li>ksirk/Jabber/jabberbytestream.cpp <span style="color: grey">(6989b8f)</span></li>
<li>ksirk/Jabber/kmessagejabber.cpp <span style="color: grey">(d0645a6)</span></li>
<li>ksirk/Sprites/animsprite.cpp <span style="color: grey">(7162042)</span></li>
<li>ksirk/Sprites/backgnd.h <span style="color: grey">(8633303)</span></li>
<li>ksirk/decoratedgameframe.cpp <span style="color: grey">(c954110)</span></li>
<li>ksirk/fightArena.h <span style="color: grey">(16312fe)</span></li>
<li>ksirk/fightArena.cpp <span style="color: grey">(e03048e)</span></li>
<li>ksirk/gestionSprites.cpp <span style="color: grey">(0bbdcb6)</span></li>
<li>ksirk/iris/src/irisnet/corelib/objectsession.cpp <span style="color: grey">(03b4f74)</span></li>
<li>ksirk/iris/src/xmpp/base64/base64.cpp <span style="color: grey">(3e2023d)</span></li>
<li>ksirk/iris/src/xmpp/cutestuff/httpconnect.cpp <span style="color: grey">(204c274)</span></li>
<li>ksirk/iris/src/xmpp/cutestuff/httppoll.cpp <span style="color: grey">(4e05ba9)</span></li>
<li>ksirk/iris/src/xmpp/xmpp-im/xmpp_vcard.cpp <span style="color: grey">(cdbd49b)</span></li>
<li>ksirk/iris/src/xmpp/xmpp-im/xmpp_xmlcommon.cpp <span style="color: grey">(29e4e1f)</span></li>
<li>ksirk/kgamewin.h <span style="color: grey">(b3dadb7)</span></li>
<li>ksirk/kgamewin.cpp <span style="color: grey">(c11006f)</span></li>
<li>ksirk/kgamewinslots.cpp <span style="color: grey">(d98a614)</span></li>
<li>ksirk/krightdialog.h <span style="color: grey">(c3da2b7)</span></li>
<li>ksirk/krightdialog.cpp <span style="color: grey">(cbac45c)</span></li>
<li>ksirk/ksirkConfigDialog.cpp <span style="color: grey">(c3e2ff0)</span></li>
<li>ksirk/mainMenu.cpp <span style="color: grey">(bcb2a9d)</span></li>
<li>ksirk/newgamesetup.cpp <span style="color: grey">(b2365c4)</span></li>
<li>ksirkskineditor/CMakeLists.txt <span style="color: grey">(ecf2d78)</span></li>
<li>ksirkskineditor/ksirkSkinEditorConfigDialog.cpp <span style="color: grey">(bf00a82)</span></li>
<li>ksirkskineditor/ksirkcontinentdefinition.ui <span style="color: grey">(76053f3)</span></li>
<li>ksirkskineditor/ksirkcountrydefinition.ui <span style="color: grey">(e7a2f68)</span></li>
<li>ksirkskineditor/ksirkskindefinition.ui <span style="color: grey">(54eee30)</span></li>
<li>ksirkskineditor/ksirkspritesdefinition.ui <span style="color: grey">(ca97e28)</span></li>
<li>ksirkskineditor/mainwindow.h <span style="color: grey">(c778c60)</span></li>
<li>ksirkskineditor/mainwindow.cpp <span style="color: grey">(e876b84)</span></li>
<li>ksirkskineditor/onu.h <span style="color: grey">(3af5a3c)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/130102/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>