<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/130100/">https://git.reviewboard.kde.org/r/130100/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On aprile 22nd, 2017, 11:54 p.m. CEST, <b>Luigi Toscano</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Sent without a ship it, and with a bad format for the commit message.</p></pre>
</blockquote>
<p>On aprile 23rd, 2017, 12:21 a.m. CEST, <b>Luigi Toscano</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Change reverted. Please discuss this on IRC before sending, the change was not complete:
- a lot of kDebug under ksirk/Jabber/ ; they have not been not converted by the script because they had a category, but they could have been easily spotted with a manual check.
- the commit message should have been a bit different. It was:
-----------------
REVIEW: 130100
[Ksirk frameworks] Port kDebug to qCDebug
All logs converted
----------------
Things to change:
* it should respect the git guidelines (first relevant summary line, max 55/60 characters+blank line+ rest of commit message. Here the blank line is missing.
* the first line should contain the description, so "Port kDebu to qCDebug"; the REVIEW is an internal detail and should go in the body of the commit message.
* [Ksirk frameworks] is not needed. This is the ksirk repository, frameworks is part of the context.
A possible commit message can be:
------------------
Port kDebug to qCDebug
All logs converted
REVIEW: 130100
------------------
I want to think that you pushed this by mistake. So please reopen this and discuss again, I'm also on IRC.</pre>
</blockquote>
<p>On aprile 23rd, 2017, 1:01 a.m. CEST, <b>Nemanja Hirsl</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Please, do not revert changes</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">There are too many files to manage for multiple reviews and a lot of conflicts to resolve between them.
Once everything is in place, we can work on details.
More important changes are comming.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It's already reverted, so let's work on fixing that first. The other change will come later, after the first one is accepted.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Multiple changes should not be a problem: git can handle them for you. You can rewrite your local history, create multiple branches. That's not a problem.</p></pre>
<br />
<p>- Luigi</p>
<br />
<p>On aprile 22nd, 2017, 11:52 p.m. CEST, Nemanja Hirsl wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Games.</div>
<div>By Nemanja Hirsl.</div>
<p style="color: grey;"><i>Updated Apr. 22, 2017, 11:52 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ksirk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">[Ksirk frameworks] Port kDebug to qCDebug</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Build and gameplay.
Logs are available with the category org.kde.ksirk
Default log level is debug.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(54910ed)</span></li>
<li>ksirk/CMakeLists.txt <span style="color: grey">(260da6a)</span></li>
<li>ksirk/Dialogs/InvasionSlider.cpp <span style="color: grey">(041992f)</span></li>
<li>ksirk/Dialogs/jabbergameui.cpp <span style="color: grey">(dd0e9a0)</span></li>
<li>ksirk/Dialogs/joingame.cpp <span style="color: grey">(c00c88a)</span></li>
<li>ksirk/Dialogs/kplayersetupwidget.cpp <span style="color: grey">(b55e170)</span></li>
<li>ksirk/Dialogs/kwaitedplayersetupdialog.cpp <span style="color: grey">(a51509e)</span></li>
<li>ksirk/Dialogs/newGameDialogImpl.cpp <span style="color: grey">(80c8717)</span></li>
<li>ksirk/Dialogs/newGameSummaryWidget.cpp <span style="color: grey">(8031cc9)</span></li>
<li>ksirk/Dialogs/restartOrExitDialogImpl.cpp <span style="color: grey">(aad96f9)</span></li>
<li>ksirk/Dialogs/tcpconnectwidget.cpp <span style="color: grey">(c3cf605)</span></li>
<li>ksirk/GameLogic/KsirkChatDelegate.cpp <span style="color: grey">(dbbbd0b)</span></li>
<li>ksirk/GameLogic/KsirkChatItem.cpp <span style="color: grey">(2d079dd)</span></li>
<li>ksirk/GameLogic/KsirkChatModel.cpp <span style="color: grey">(1e3cd03)</span></li>
<li>ksirk/GameLogic/aiColsonPlayer.cpp <span style="color: grey">(19829fb)</span></li>
<li>ksirk/GameLogic/aiplayer.cpp <span style="color: grey">(50c9757)</span></li>
<li>ksirk/GameLogic/continent.cpp <span style="color: grey">(b97713a)</span></li>
<li>ksirk/GameLogic/country.cpp <span style="color: grey">(eae46c9)</span></li>
<li>ksirk/GameLogic/eventslistproperty.cpp <span style="color: grey">(9553514)</span></li>
<li>ksirk/GameLogic/gameautomaton.cpp <span style="color: grey">(ba41d50)</span></li>
<li>ksirk/GameLogic/goal.cpp <span style="color: grey">(b4a515e)</span></li>
<li>ksirk/GameLogic/onu.cpp <span style="color: grey">(30a9d9c)</span></li>
<li>ksirk/GameLogic/player.cpp <span style="color: grey">(8bc8384)</span></li>
<li>ksirk/Jabber/jabberaccount.cpp <span style="color: grey">(b0579cc)</span></li>
<li>ksirk/Jabber/jabberbasecontact.cpp <span style="color: grey">(de41445)</span></li>
<li>ksirk/Jabber/jabberbookmarks.cpp <span style="color: grey">(c0d1054)</span></li>
<li>ksirk/Jabber/jabberbytestream.cpp <span style="color: grey">(39ce88f)</span></li>
<li>ksirk/Jabber/jabbercapabilitiesmanager.cpp <span style="color: grey">(514e119)</span></li>
<li>ksirk/Jabber/jabberclient.cpp <span style="color: grey">(ca5e9f5)</span></li>
<li>ksirk/Jabber/jabberconnector.cpp <span style="color: grey">(a41b384)</span></li>
<li>ksirk/Jabber/jabbercontact.cpp <span style="color: grey">(7458fdb)</span></li>
<li>ksirk/Jabber/jabbercontactpool.cpp <span style="color: grey">(4496353)</span></li>
<li>ksirk/Jabber/jabbergroupcontact.cpp <span style="color: grey">(2cafdf9)</span></li>
<li>ksirk/Jabber/jabbergroupmembercontact.cpp <span style="color: grey">(b5df565)</span></li>
<li>ksirk/Jabber/jabberprotocol.cpp <span style="color: grey">(2a71897)</span></li>
<li>ksirk/Jabber/jabberresource.cpp <span style="color: grey">(2ed0732)</span></li>
<li>ksirk/Jabber/jabberresourcepool.cpp <span style="color: grey">(c6b4f97)</span></li>
<li>ksirk/Jabber/kmessagejabber.h <span style="color: grey">(fb08076)</span></li>
<li>ksirk/Jabber/kmessagejabber.cpp <span style="color: grey">(cdd1b5d)</span></li>
<li>ksirk/Jabber/privacylist.cpp <span style="color: grey">(67f9139)</span></li>
<li>ksirk/Jabber/privacylistitem.cpp <span style="color: grey">(40f7569)</span></li>
<li>ksirk/Jabber/privacymanager.cpp <span style="color: grey">(02b2f4d)</span></li>
<li>ksirk/SaveLoad/ksirkgamexmlhandler.cpp <span style="color: grey">(209d595)</span></li>
<li>ksirk/Sprites/animsprite.cpp <span style="color: grey">(3b2c982)</span></li>
<li>ksirk/Sprites/animspritesgroup.cpp <span style="color: grey">(1adb2a0)</span></li>
<li>ksirk/Sprites/animspriteslist.h <span style="color: grey">(8084ce5)</span></li>
<li>ksirk/Sprites/animspriteslist.cpp <span style="color: grey">(cab46ce)</span></li>
<li>ksirk/Sprites/animspritespool.cpp <span style="color: grey">(5fceca5)</span></li>
<li>ksirk/Sprites/arrowsprite.cpp <span style="color: grey">(7e7646b)</span></li>
<li>ksirk/Sprites/backgnd.cpp <span style="color: grey">(736fc30)</span></li>
<li>ksirk/Sprites/cannonsprite.cpp <span style="color: grey">(3e99d3c)</span></li>
<li>ksirk/decoratedgameframe.cpp <span style="color: grey">(028e435)</span></li>
<li>ksirk/fightArena.cpp <span style="color: grey">(de17ee1)</span></li>
<li>ksirk/gestionSprites.cpp <span style="color: grey">(90a3fb9)</span></li>
<li>ksirk/kgamewin.cpp <span style="color: grey">(50795e0)</span></li>
<li>ksirk/kgamewinslots.cpp <span style="color: grey">(cb5d210)</span></li>
<li>ksirk/krightdialog.cpp <span style="color: grey">(8f0095c)</span></li>
<li>ksirk/ksirkConfigDialog.cpp <span style="color: grey">(c84b181)</span></li>
<li>ksirk/main.cpp <span style="color: grey">(519dfe7)</span></li>
<li>ksirk/mainMenu.cpp <span style="color: grey">(935617b)</span></li>
<li>ksirk/newgamesetup.cpp <span style="color: grey">(6384c09)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/130100/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>