<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/130098/">https://git.reviewboard.kde.org/r/130098/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 22nd, 2017, 12:42 p.m. UTC, <b>Luigi Toscano</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I forgot that there was also another script, convert-kdebug-with-argument.sh, which uses the more modern ecm_qt_declare_logging_category macro. Could you please try to use that macro, which basically creates the ksirkdebug.* files for you?</pre>
</blockquote>
<p>On April 22nd, 2017, 2:31 p.m. UTC, <b>Nemanja Hirsl</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Tried with this one, the outcome is the same.</p></pre>
</blockquote>
<p>On April 22nd, 2017, 2:35 p.m. UTC, <b>Luigi Toscano</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm pretty sure that it's not the same: it should not generate the ksirkdebug.* files, and it should tell you to add the call toecm_qt_declare_logging_category. Please recheck.</pre>
</blockquote>
<p>On April 22nd, 2017, 2:42 p.m. UTC, <b>Nemanja Hirsl</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This is console outoput:
./convert-kdebug-with-argument.sh KSIRK_LOG org.kde.ksirk KSIRK_LOG ksirkdebug
1) Add ksirkdebug.cpp to CMakeLists.txt
2) Add #include <QDebug> + #include "ksirkdebug.h" to each file which was changed
3) Verify that it compiles :)
4) If you find bugs fix them please</p></pre>
</blockquote>
<p>On April 22nd, 2017, 2:46 p.m. UTC, <b>Luigi Toscano</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Update your git checkout of kde-dev-scripts (which is something to do every time you use it). The script was changed 3 weeks ago.</p></pre>
</blockquote>
<p>On April 22nd, 2017, 3:03 p.m. UTC, <b>Nemanja Hirsl</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Yap, just did that, but still, it doesn't convert anything :(
There are just few files where includes are changed, however none of the kDebug() are converted.</p></pre>
</blockquote>
<p>On April 22nd, 2017, 3:10 p.m. UTC, <b>Luigi Toscano</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Just tried it.
It converts every kDebug() calls with the exception of the files inside ksirk/Jabber/, which already have a category. This is fine.
So please recheck it (on a clean snapshot).</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Unfortunately, I can't make it work.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">nhirsl_suse@euclid:~/Dev/KDE/src/kdegames/ksirk> git log</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">commit 4c372d89bf54dba338315b70af51c476c5906129
Merge: 1940f0a b0c07d5
Author: Luigi Toscano <a href="mailto:luigi.toscano@tiscali.it" style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">luigi.toscano@tiscali.it</a>
Date: Sat Apr 15 20:22:27 2017 +0200</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%"><span></span>Merge remote-tracking branch 'origin/master' into frameworks
Use the variable provided by ECM for the appdata directory.
</pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">commit b0c07d53396c09ba698969e7da58e29ab72254e2
Author: Burkhard Lück <a href="mailto:lueck@hube-lueck.de" style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">lueck@hube-lueck.de</a>
Date: Sat Apr 15 20:19:54 2017 +0200</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%"><span></span>Add appdata file for KSirk in master branch + use reverse dns naming scheme for both deskop files
Differential Revision: https://phabricator.kde.org/D5387
</pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">nhirsl_suse@euclid:~/Dev/KDE/src/kdegames/ksirk> git status
On branch newLogs
Untracked files:
(use "git add <file>..." to include in what will be committed)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">nothing added to commit but untracked files present (use "git add" to track)
nhirsl_suse@euclid:~/Dev/KDE/src/kdegames/ksirk> ./convert-kdebug-with-argument.sh KSIRK_LOG org.kde.ksirk KSIRK_LOG ksirkdebug
1) add ecm_qt_declare_logging_category(<file>_SRCS HEADER ksirkdebug.h IDENTIFIER KSIRK_LOG CATEGORY_NAME org.kde.ksirk) to CMakeLists.txt
2) #include "ksirkdebug.h" to each file which was changed and where it is missing
3) Verify that it compiles :)
4) If you find bugs fix them please
nhirsl_suse@euclid:~/Dev/KDE/src/kdegames/ksirk> git status
On branch newLogs
Changes not staged for commit:
(use "git add <file>..." to update what will be committed)
(use "git checkout -- <file>..." to discard changes in working directory)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%"><span></span> modified: ksirk/Dialogs/jabbergameui.cpp
modified: ksirk/Dialogs/joingame.cpp
modified: ksirk/Dialogs/newGameDialogImpl.cpp
modified: ksirk/Dialogs/newGameSummaryWidget.cpp
modified: ksirk/Dialogs/tcpconnectwidget.cpp
modified: ksirk/Jabber/jabberclient.cpp
modified: ksirk/kgamewin.cpp
modified: ksirk/newgamesetup.cpp
</pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Untracked files:
(use "git add <file>..." to include in what will be committed)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">no changes added to commit (use "git add" and/or "git commit -a")</p></pre>
<br />
<p>- Nemanja</p>
<br />
<p>On April 22nd, 2017, 2:30 p.m. UTC, Nemanja Hirsl wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Games.</div>
<div>By Nemanja Hirsl.</div>
<p style="color: grey;"><i>Updated April 22, 2017, 2:30 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ksirk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">[Ksirk frameworks] Logging port from kDebug to qCDebug</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">After applyng convert-qkdebug-to-qcdebug.sh, a few changes made in order to compile succesfully.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Application tested and logs are available:
./ksirk
logksirk: Hello KsirK
logksirk: Creating main window
...</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>ksirk/CMakeLists.txt <span style="color: grey">(260da6a)</span></li>
<li>ksirk/Dialogs/InvasionSlider.cpp <span style="color: grey">(041992f)</span></li>
<li>ksirk/Dialogs/jabbergameui.cpp <span style="color: grey">(dd0e9a0)</span></li>
<li>ksirk/Dialogs/joingame.cpp <span style="color: grey">(c00c88a)</span></li>
<li>ksirk/Dialogs/kplayersetupwidget.cpp <span style="color: grey">(b55e170)</span></li>
<li>ksirk/Dialogs/kwaitedplayersetupdialog.cpp <span style="color: grey">(a51509e)</span></li>
<li>ksirk/Dialogs/newGameDialogImpl.cpp <span style="color: grey">(80c8717)</span></li>
<li>ksirk/Dialogs/newGameSummaryWidget.cpp <span style="color: grey">(8031cc9)</span></li>
<li>ksirk/Dialogs/restartOrExitDialogImpl.cpp <span style="color: grey">(aad96f9)</span></li>
<li>ksirk/Dialogs/tcpconnectwidget.cpp <span style="color: grey">(c3cf605)</span></li>
<li>ksirk/GameLogic/KsirkChatDelegate.cpp <span style="color: grey">(dbbbd0b)</span></li>
<li>ksirk/GameLogic/KsirkChatItem.cpp <span style="color: grey">(2d079dd)</span></li>
<li>ksirk/GameLogic/KsirkChatModel.cpp <span style="color: grey">(1e3cd03)</span></li>
<li>ksirk/GameLogic/aiColsonPlayer.cpp <span style="color: grey">(19829fb)</span></li>
<li>ksirk/GameLogic/aiplayer.cpp <span style="color: grey">(50c9757)</span></li>
<li>ksirk/GameLogic/continent.cpp <span style="color: grey">(b97713a)</span></li>
<li>ksirk/GameLogic/country.cpp <span style="color: grey">(eae46c9)</span></li>
<li>ksirk/GameLogic/eventslistproperty.cpp <span style="color: grey">(9553514)</span></li>
<li>ksirk/GameLogic/gameautomaton.cpp <span style="color: grey">(ba41d50)</span></li>
<li>ksirk/GameLogic/goal.cpp <span style="color: grey">(b4a515e)</span></li>
<li>ksirk/GameLogic/onu.cpp <span style="color: grey">(30a9d9c)</span></li>
<li>ksirk/GameLogic/player.cpp <span style="color: grey">(8bc8384)</span></li>
<li>ksirk/Jabber/jabberaccount.cpp <span style="color: grey">(b0579cc)</span></li>
<li>ksirk/Jabber/jabberbasecontact.cpp <span style="color: grey">(de41445)</span></li>
<li>ksirk/Jabber/jabberbookmarks.cpp <span style="color: grey">(c0d1054)</span></li>
<li>ksirk/Jabber/jabberbytestream.cpp <span style="color: grey">(39ce88f)</span></li>
<li>ksirk/Jabber/jabbercapabilitiesmanager.cpp <span style="color: grey">(514e119)</span></li>
<li>ksirk/Jabber/jabberclient.cpp <span style="color: grey">(ca5e9f5)</span></li>
<li>ksirk/Jabber/jabberconnector.cpp <span style="color: grey">(a41b384)</span></li>
<li>ksirk/Jabber/jabbercontact.cpp <span style="color: grey">(7458fdb)</span></li>
<li>ksirk/Jabber/jabbercontactpool.cpp <span style="color: grey">(4496353)</span></li>
<li>ksirk/Jabber/jabbergroupcontact.cpp <span style="color: grey">(2cafdf9)</span></li>
<li>ksirk/Jabber/jabbergroupmembercontact.cpp <span style="color: grey">(b5df565)</span></li>
<li>ksirk/Jabber/jabberprotocol.cpp <span style="color: grey">(2a71897)</span></li>
<li>ksirk/Jabber/jabberresource.cpp <span style="color: grey">(2ed0732)</span></li>
<li>ksirk/Jabber/jabberresourcepool.cpp <span style="color: grey">(c6b4f97)</span></li>
<li>ksirk/Jabber/kmessagejabber.h <span style="color: grey">(fb08076)</span></li>
<li>ksirk/Jabber/kmessagejabber.cpp <span style="color: grey">(cdd1b5d)</span></li>
<li>ksirk/Jabber/privacylist.cpp <span style="color: grey">(67f9139)</span></li>
<li>ksirk/Jabber/privacylistitem.cpp <span style="color: grey">(40f7569)</span></li>
<li>ksirk/Jabber/privacymanager.cpp <span style="color: grey">(02b2f4d)</span></li>
<li>ksirk/SaveLoad/ksirkgamexmlhandler.cpp <span style="color: grey">(209d595)</span></li>
<li>ksirk/Sprites/animsprite.cpp <span style="color: grey">(3b2c982)</span></li>
<li>ksirk/Sprites/animspritesgroup.cpp <span style="color: grey">(1adb2a0)</span></li>
<li>ksirk/Sprites/animspriteslist.h <span style="color: grey">(8084ce5)</span></li>
<li>ksirk/Sprites/animspriteslist.cpp <span style="color: grey">(cab46ce)</span></li>
<li>ksirk/Sprites/animspritespool.cpp <span style="color: grey">(5fceca5)</span></li>
<li>ksirk/Sprites/arrowsprite.cpp <span style="color: grey">(7e7646b)</span></li>
<li>ksirk/Sprites/backgnd.cpp <span style="color: grey">(736fc30)</span></li>
<li>ksirk/Sprites/cannonsprite.cpp <span style="color: grey">(3e99d3c)</span></li>
<li>ksirk/decoratedgameframe.cpp <span style="color: grey">(028e435)</span></li>
<li>ksirk/fightArena.cpp <span style="color: grey">(de17ee1)</span></li>
<li>ksirk/gestionSprites.cpp <span style="color: grey">(90a3fb9)</span></li>
<li>ksirk/iris/src/CMakeLists.txt <span style="color: grey">(da2a0ff)</span></li>
<li>ksirk/iris/src/xmpp/sasl/digestmd5response.cpp <span style="color: grey">(483690d)</span></li>
<li>ksirk/iris/src/xmpp/xmpp-core/compressionhandler.cpp <span style="color: grey">(e3f0add)</span></li>
<li>ksirk/iris/src/xmpp/xmpp-core/simplesasl.cpp <span style="color: grey">(cc9fac4)</span></li>
<li>ksirk/iris/src/xmpp/xmpp-im/client.cpp <span style="color: grey">(9b51302)</span></li>
<li>ksirk/kgamewin.cpp <span style="color: grey">(50795e0)</span></li>
<li>ksirk/kgamewinslots.cpp <span style="color: grey">(cb5d210)</span></li>
<li>ksirk/krightdialog.cpp <span style="color: grey">(8f0095c)</span></li>
<li>ksirk/ksirkConfigDialog.cpp <span style="color: grey">(c84b181)</span></li>
<li>ksirk/ksirkdebug.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>ksirk/ksirkdebug.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>ksirk/main.cpp <span style="color: grey">(519dfe7)</span></li>
<li>ksirk/mainMenu.cpp <span style="color: grey">(935617b)</span></li>
<li>ksirk/newgamesetup.cpp <span style="color: grey">(6384c09)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/130098/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>