<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129295/">https://git.reviewboard.kde.org/r/129295/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I disagree, our apps expose the actions via dbus as they used to do via dcop, this is useful.</p></pre>
<br />
<p>- Albert Astals Cid</p>
<br />
<p>On October 31st, 2016, 11:40 a.m. UTC, Harald Sitter wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Games and Aleix Pol Gonzalez.</div>
<div>By Harald Sitter.</div>
<p style="color: grey;"><i>Updated Oct. 31, 2016, 11:40 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kblocks
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">kblocks provides no service, so it having startuptype multi is not
beneficial to anyone (multi means ktoolinvocation will wait for
registration before considering the service started).
without multi startup there is no reason to use dbusaddons at all as there
is no reason to register on dbus as kblocks has no actual dbus API 3rd
parties should use. so, remove all of dbus.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">builds, doesn't use dbus anymore, plasma and krunner can still start it without problems</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(d90453d8da079aeaba13b6a129cccb48b56a5ec6)</span></li>
<li>main.cpp <span style="color: grey">(349e22e0b4beb384e2fdd78d20abdd948d5ef9e9)</span></li>
<li>org.kde.kblocks.desktop <span style="color: grey">(042cb40afdd2474eafb4c9284dcaa16fdf33de4b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129295/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>