<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127708/">https://git.reviewboard.kde.org/r/127708/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 27th, 2016, 5:20 p.m. CDT, <b>Frederik Schwarzer</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/127708/diff/1/?file=456428#file456428line23" style="color: black; font-weight: bold; text-decoration: underline;">src/kbreakout_debug.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">23</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="n">Q_DECLARE_LOGGING_CATEGORY</span><span class="p">(</span><span class="n">KBREAKOUT_General</span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Is there a reason to use the word "General" here? Since other games use "LOG". Not really in favor or against any of those but I think we should be consistent.</p></pre>
</blockquote>
<p>On April 29th, 2016, 1:11 p.m. CDT, <b>Julian Helfferich</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Yes, there is: We might want to add further categories in the future such as KBREAKOUT_Graphics or KBREAKOUT_LevelLoader. I think LOG does not help to distinguish logging categories as they all log information of some kind. And having several different categories is the basic ideas of QLoggingCategories.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">In order of consistency, I would offer to change "LOG" to "General" for all games using it.</p></pre>
</blockquote>
<p>On April 30th, 2016, 5:45 a.m. CDT, <b>Frederik Schwarzer</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Look what you did there. You made me read something and now I know more than I knew before. How dare you! :D</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">OK, I never thought of QLoggingCategories that way. I did not know about qCCritical/Warning/Info. So far, I thought it was supposed to be used for different applications to make reading files like .xsession-errors actually possible again. But after reading the docs, it's clear that QLoggingCategories as two different purposes. On one hand there are the categories info, debug, warning and critical and on the other hand, there are "areas" where everyone can define custom "categories" that then work similarily.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">In that light, "General" does make much more sense than "LOG". I am in favour of changing all the games and would also offer my help. After all, it's just some sed/compile/commit action. :)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">But lets wait for some more opinions.</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Honestly, I haven't thought about different applications writing to the same log file. I can see how logging categories make a great difference there. But even just for the output of a single application, I like the additional info which part of the program is writing the debug message. By the way, libkdegames already uses different categories, including "games.lib", "games.highscore", and "games.ui". I was also quite liberal in declaring logging categories in KBlocks.</p></pre>
<br />
<p>- Julian</p>
<br />
<p>On April 22nd, 2016, 10:55 a.m. CDT, Julian Helfferich wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Games.</div>
<div>By Julian Helfferich.</div>
<p style="color: grey;"><i>Updated April 22, 2016, 10:55 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kbreakout
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I am currently trying to track down some of the more intricate bugs of kbreakout, such as bug 354517, bug 328812, and bug 328811. To get to the root of the problem, a lot of debug output is necessary.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">In the process, I learned about QLoggingCategories and added them to kbreakout. Generally, I looked at how other games use QLoggingCategories and copied the approach from Laurent Montel (KSnakeDuel, Grantier) and Frederik Schwarzer (KMahjongg). However, as I am no expert in Qt, I would appreciate your feedback.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Compiled, played, confirmed that output is written to console.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/CMakeLists.txt <span style="color: grey">(eac51ff)</span></li>
<li>src/canvaswidget.cpp <span style="color: grey">(1d80bfa)</span></li>
<li>src/gameengine.cpp <span style="color: grey">(541f60c)</span></li>
<li>src/kbreakout_debug.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/kbreakout_debug.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/levelloader.cpp <span style="color: grey">(e609536)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127708/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>