<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126124/">https://git.reviewboard.kde.org/r/126124/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On Dezember 27th, 2015, 12:32 nachm. UTC, <b>Laurent Montel</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Seems ok for me.
Ship it!
Thanks</p></pre>
</blockquote>
<p>On Dezember 28th, 2015, 3:17 nachm. UTC, <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">There's two issues here:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">A) Manoharan does not have a developer account
B) knights is part of extragear</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">A) is easily solvable, Laurent or me or someone else can commit the code but committing the code without making a release at some point doesn't give us much.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Because B) a release won't automatically happen, so we need someone to do a release.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Manoharan do you feel like you would want to become the maintainer of knights? After all noone else has done much work on it since 2012. By that we would give you commit access and you should also commit to doing a release.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">What do you think?</p></pre>
</blockquote>
<p>On Dezember 30th, 2015, 5:43 vorm. UTC, <b>Manoharan Sundaramoorthy</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Sure, I would require some help in the beginning though.</p></pre>
</blockquote>
<p>On Januar 10th, 2016, 1:51 vorm. UTC, <b>Christoph Feck</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">There already was a frameworks branch. The porting status page was created to help deciding which projects need help.</pre>
</blockquote>
<p>On März 20th, 2016, 9:33 vorm. UTC, <b>Frederik Schwarzer</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Have these issues been resolved?</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Frederik, the port is completed and Manoharan can push to remote. I'm fixing the bugs now in knights and we can discuss later when and how to release once all the bugs are fixed. We had also a discussion about this on kde-games-devel in January.</p></pre>
<br />
<p>- Alexander</p>
<br />
<p>On Dezember 27th, 2015, 9:56 vorm. UTC, Manoharan Sundaramoorthy wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Games, Knights and Miha Čančula.</div>
<div>By Manoharan Sundaramoorthy.</div>
<p style="color: grey;"><i>Updated Dez. 27, 2015, 9:56 vorm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
knights
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Knights: Port to KF5/QT5</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><ol style="padding: 0;text-rendering: inherit;margin: 0 0 0 2em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Tested Playing against gnuchess</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Two human players</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Playing with clock</li>
</ol></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(ed25a68)</span></li>
<li>doc/CMakeLists.txt <span style="color: grey">(5aad7c2)</span></li>
<li>icons/16-apps-knights.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>icons/32-apps-knights.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>icons/48-apps-knights.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>icons/64-apps-knights.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>icons/CMakeLists.txt <span style="color: grey">(7affd27)</span></li>
<li>icons/hi16-app-knights.png <span style="color: grey">(ee4a3d9)</span></li>
<li>icons/hi32-app-knights.png <span style="color: grey">(120c7b2)</span></li>
<li>icons/hi48-app-knights.png <span style="color: grey">(26684f0)</span></li>
<li>icons/hi64-app-knights.png <span style="color: grey">(df75196)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(6d77801)</span></li>
<li>src/board.h <span style="color: grey">(d464bd1)</span></li>
<li>src/board.cpp <span style="color: grey">(775cfd8)</span></li>
<li>src/clock.h <span style="color: grey">(340c885)</span></li>
<li>src/clock.cpp <span style="color: grey">(1e13366)</span></li>
<li>src/clockwidget.h <span style="color: grey">(5686a95)</span></li>
<li>src/clockwidget.cpp <span style="color: grey">(2a4e744)</span></li>
<li>src/core/item.cpp <span style="color: grey">(30fe74e)</span></li>
<li>src/core/move.h <span style="color: grey">(50e32b0)</span></li>
<li>src/core/move.cpp <span style="color: grey">(4f7ca0e)</span></li>
<li>src/core/piece.cpp <span style="color: grey">(4564ae8)</span></li>
<li>src/core/pos.h <span style="color: grey">(343a8b5)</span></li>
<li>src/core/pos.cpp <span style="color: grey">(8623c27)</span></li>
<li>src/customdifficultydialog.ui <span style="color: grey">(f9f7b29)</span></li>
<li>src/enginesettings.h <span style="color: grey">(2942ad1)</span></li>
<li>src/enginesettings.cpp <span style="color: grey">(4802ce0)</span></li>
<li>src/enginesettings.ui <span style="color: grey">(eb59af2)</span></li>
<li>src/externalcontrol.h <span style="color: grey">(40dbf55)</span></li>
<li>src/externalcontrol.cpp <span style="color: grey">(1467491)</span></li>
<li>src/gamedialog.h <span style="color: grey">(5518290)</span></li>
<li>src/gamedialog.cpp <span style="color: grey">(2d0a124)</span></li>
<li>src/gamedialog.ui <span style="color: grey">(436887d)</span></li>
<li>src/gamemanager.h <span style="color: grey">(fe7f883)</span></li>
<li>src/gamemanager.cpp <span style="color: grey">(c9d9566)</span></li>
<li>src/historywidget.h <span style="color: grey">(0d9f823)</span></li>
<li>src/historywidget.cpp <span style="color: grey">(9f7f3fd)</span></li>
<li>src/historywidget.ui <span style="color: grey">(aacc0be)</span></li>
<li>src/knights.cpp <span style="color: grey">(cb688a7)</span></li>
<li>src/knights.desktop <span style="color: grey">(400cf57)</span></li>
<li>src/knightsview.h <span style="color: grey">(40df529)</span></li>
<li>src/knightsview.cpp <span style="color: grey">(5451eb9)</span></li>
<li>src/main.cpp <span style="color: grey">(504fcc5)</span></li>
<li>src/offerwidget.cpp <span style="color: grey">(0993ae2)</span></li>
<li>src/org.kde.knights.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/popup.ui <span style="color: grey">(d4665af)</span></li>
<li>src/promotiondialog.ui <span style="color: grey">(810e67d)</span></li>
<li>src/proto/chatwidget.h <span style="color: grey">(4afcdf6)</span></li>
<li>src/proto/chatwidget.cpp <span style="color: grey">(fa209f9)</span></li>
<li>src/proto/chatwidget.ui <span style="color: grey">(82ff8b7)</span></li>
<li>src/proto/computerprotocol.h <span style="color: grey">(619071f)</span></li>
<li>src/proto/computerprotocol.cpp <span style="color: grey">(a0b032f)</span></li>
<li>src/proto/ficsdialog.h <span style="color: grey">(93d5564)</span></li>
<li>src/proto/ficsdialog.cpp <span style="color: grey">(d89a07c)</span></li>
<li>src/proto/ficsdialog.ui <span style="color: grey">(8eea2e7)</span></li>
<li>src/proto/ficsprotocol.h <span style="color: grey">(3d3e395)</span></li>
<li>src/proto/ficsprotocol.cpp <span style="color: grey">(2c9b07d)</span></li>
<li>src/proto/localprotocol.cpp <span style="color: grey">(711ec5c)</span></li>
<li>src/proto/protocol.cpp <span style="color: grey">(e489d33)</span></li>
<li>src/proto/seekgraph.h <span style="color: grey">(cba3b5f)</span></li>
<li>src/proto/seekgraph.cpp <span style="color: grey">(3c83591)</span></li>
<li>src/proto/textprotocol.h <span style="color: grey">(8216f24)</span></li>
<li>src/proto/textprotocol.cpp <span style="color: grey">(d6f5290)</span></li>
<li>src/proto/uciprotocol.cpp <span style="color: grey">(69d7efb)</span></li>
<li>src/proto/xboardprotocol.h <span style="color: grey">(280d18a)</span></li>
<li>src/proto/xboardprotocol.cpp <span style="color: grey">(01fb4ae)</span></li>
<li>src/rules/chessrules.cpp <span style="color: grey">(3e993e4)</span></li>
<li>src/rules/rules.h <span style="color: grey">(032cde4)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126124/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>