<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Mar 21, 2016 at 1:32 PM, Alexander Semke <span dir="ltr"><<a href="mailto:alexander.semke@web.de" target="_blank">alexander.semke@web.de</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span class="">> Tried to reproduce, works just fine here.<br>
> You're trying the kf5 build, right?<br>
</span>Yes, kf5 build. Does it work for you if you select "Fritz look alike" (the<br>
board looks broken with this theme here) and then select another theme?<br>
<span class=""><br>
> Do you have a valgrind trace or something?<br>
</span>==20236== Invalid read of size 4<br>
==20236== at 0x5143A93: KGameRendererClient::setRenderSize(QSize const&)<br>
(in /usr/lib64/libKF5KDEGames.so.7.0.0)<br>
==20236== by 0x4C79ED: Knights::Board::updateGraphics() (board.cpp:467)<br>
==20236== by 0x4C792D: Knights::Board::updateTheme() (board.cpp:462)<br>
<br>
and many other "invalid read of size"-errors initiated in<br>
Knights::Board::updateTheme()<br>
<span class=""><br>
> BTW, the current master doesn't build<br>
> <a href="https://build.kde.org/job/knights%20master%20kf5-qt5/PLATFORM=Linux,compiler" rel="noreferrer" target="_blank">https://build.kde.org/job/knights%20master%20kf5-qt5/PLATFORM=Linux,compiler</a><br>
> =gcc/24/console<br>
</span>I see. Those errors are because of the connect-statements with the new Qt<br>
signal-slog syntax introduced by Manoharan during his port to kf5. This never<br>
worked for me, neither with g++-4.8 nor with g++-5. We had a small discussion<br>
about this in the old thread "porting and the next release of knights".<br>
Currently, I deactivated those three connects to get knights compiled. I'll<br>
have a look at it again soon.<br></blockquote><div>I dont think the reason for those errors are because of my changes. The link quotes two errors:<br></div><div>1. klocale.h not found.<br></div><div>Looks a recent change includes of "klocale.h" instead of "KLocalizedString" in gamemanager.cpp<br><br>2. error: ‘void Knights::MainWindow::fileSave()’ is private</div><div> This too a change in knights.h for fileSave() from public slot to private slot.<br><br></div><div>With the below changes, it compiles for me:<br>-----------<br>diff --git a/src/gamemanager.cpp b/src/gamemanager.cpp<br>index 0f5aa97..2cafc15 100644<br>--- a/src/gamemanager.cpp<br>+++ b/src/gamemanager.cpp<br>@@ -36,7 +36,7 @@<br> #include "knightsdebug.h"<br> <br> #include <KgDifficulty><br>-#include <klocale.h><br>+#include <KLocalizedString><br> <br> #ifdef HAVE_SPEECH<br> #include <QtTextToSpeech><br>diff --git a/src/knights.h b/src/knights.h<br>index ad50c38..114f9c2 100644<br>--- a/src/knights.h<br>+++ b/src/knights.h<br>@@ -46,10 +46,12 @@ class MainWindow : public KXmlGuiWindow<br> public:<br> MainWindow();<br> <br>+public Q_SLOTS:<br>+ void fileSave();<br>+<br> private Q_SLOTS:<br> void fileNew();<br> void fileLoad();<br>- void fileSave();<br> void fileSaveAs();<br> void pauseGame(bool);<br> void undo();<br> <br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<span class=""><br>
> BTW2, you have a valgrind warning just starting up<br>
</span>> [...]<br>
There are for sure more of such problems in the code. I'm going through the<br>
bugs reported on <a href="http://bugs.kde.org" rel="noreferrer" target="_blank">bugs.kde.org</a> now and do some cleanup in the code. Many of<br>
those errors/warning will be corrected during this cleanup. After that I'll do<br>
dedicated valgrding sessionis. I pushed a fix now for the unitialized members.<br>
<span class=""><font color="#888888"><br>
<br>
--<br>
Alexander<br>
</font></span><div class=""><div class="h5">_______________________________________________<br>
kde-games-devel mailing list<br>
<a href="mailto:kde-games-devel@kde.org">kde-games-devel@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/kde-games-devel" rel="noreferrer" target="_blank">https://mail.kde.org/mailman/listinfo/kde-games-devel</a><br>
</div></div></blockquote></div><br></div></div>