<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126124/">https://git.reviewboard.kde.org/r/126124/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/126124/diff/5/?file=425290#file425290line57" style="color: black; font-weight: bold; text-decoration: underline;">src/CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 5)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">52</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb"><span class="hl">qt4_add</span>_dbus_interface<span class="hl">s</span></span><span class="p">(</span><span class="s">knights_SRCS</span> <span class="o"><span class="hl">${</span></span><span class="nv"><span class="hl">KDE4_DBUS_INTERFACES_DIR</span></span><span class="o"><span class="hl">}</span></span><span class="s"><span class="hl">/</span>org.kde.KSpeech.xml</span><span class="p">)</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">57</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="c"><span class="hl">#qt5_generate</span>_dbus_interface(knights_SRCS org.kde.KSpeech.xml)</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">remove it as we don't have it now</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/126124/diff/5/?file=425290#file425290line80" style="color: black; font-weight: bold; text-decoration: underline;">src/CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 5)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">80</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="c">#${KDE4_PLASMA_LIBS} ${QT_QTNETWORK_LIBRARY})</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Remove it as it's not necessary</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/126124/diff/5/?file=425299#file425299line339" style="color: black; font-weight: bold; text-decoration: underline;">src/core/move.cpp</a>
<span style="font-weight: normal;">
(Diff revision 5)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">namespace Knights</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">339</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n"><span class="hl">kError</span></span><span class="p">()</span> <span class="o"><<</span> <span class="s">"Can't reverse the move from short algebraic notation"</span><span class="p">;</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">338</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n"><span class="hl">qCritical</span></span><span class="p">()</span> <span class="o"><<</span> <span class="s">"Can't reverse the move from short algebraic notation"</span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">qCCritical(..)</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/126124/diff/5/?file=425313#file425313line940" style="color: black; font-weight: bold; text-decoration: underline;">src/gamemanager.cpp</a>
<span style="font-weight: normal;">
(Diff revision 5)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void Manager::setDifficulty(int searchDepth, int memorySize)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">923</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">ui</span><span class="o">-></span><span class="n">searchDepthIntSpinBox</span><span class="o">-></span><span class="n">setSuffix</span> <span class="p">(</span> <span class="n">ki18np</span><span class="p">(</span><span class="s">" move"</span><span class="p">,</span> <span class="s">" moves"</span><span class="p">)</span> <span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">930</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">ui</span><span class="o">-></span><span class="n">searchDepthIntSpinBox</span><span class="o">-></span><span class="n">setSuffix</span> <span class="p">(</span> <span class="n">ki18np</span><span class="p">(</span><span class="s">" move"</span><span class="p">,</span> <span class="s">" moves"</span><span class="p">)<span class="hl">.</span></span><span class="n"><span class="hl">toString</span></span><span class="p"><span class="hl">()</span></span> <span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">use kpluralhandlingspinbox.cpp from ktextwidget</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/126124/diff/5/?file=425319#file425319line1" style="color: black; font-weight: bold; text-decoration: underline;">src/knightsdebug.h</a>
<span style="font-weight: normal;">
(Diff revision 5)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">1</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cm">/*</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">use autogenerated debug file
example ecm_qt_declare_logging_category(kmail_common_SRCS HEADER kmail_debug.h IDENTIFIER KMAIL_LOG CATEGORY_NAME log_kmail)</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/126124/diff/5/?file=425344#file425344line694" style="color: black; font-weight: bold; text-decoration: underline;">src/rules/chessrules.cpp</a>
<span style="font-weight: normal;">
(Diff revision 5)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void ChessRules::changeNotation ( Move* move, Move::Notation notation, Color color )</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">693</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n"><span class="hl">k</span>Warning</span><span class="p">()</span> <span class="o"><<</span> <span class="s">"Unknown move notation"</span> <span class="o"><<</span> <span class="n">move</span><span class="o">-></span><span class="n">string</span><span class="p">();</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">693</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n"><span class="hl">q</span>Warning</span><span class="p">()</span> <span class="o"><<</span> <span class="s">"Unknown move notation"</span> <span class="o"><<</span> <span class="n">move</span><span class="o">-></span><span class="n">string</span><span class="p">();</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">qCWarning(...)</p></pre>
</div>
</div>
<br />
<p>- Laurent Montel</p>
<br />
<p>On décembre 22nd, 2015, 6:04 matin UTC, Manoharan Sundaramoorthy wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Games, Knights and Miha Čančula.</div>
<div>By Manoharan Sundaramoorthy.</div>
<p style="color: grey;"><i>Updated déc. 22, 2015, 6:04 matin</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
knights
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Knights: Port to KF5/QT5</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><ol style="padding: 0;text-rendering: inherit;margin: 0 0 0 2em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Tested Playing against gnuchess</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Two human players</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Playing with clock</li>
</ol></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(ed25a68)</span></li>
<li>doc/CMakeLists.txt <span style="color: grey">(5aad7c2)</span></li>
<li>icons/16-apps-knights.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>icons/32-apps-knights.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>icons/48-apps-knights.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>icons/64-apps-knights.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>icons/CMakeLists.txt <span style="color: grey">(7affd27)</span></li>
<li>icons/hi16-app-knights.png <span style="color: grey">(ee4a3d9)</span></li>
<li>icons/hi32-app-knights.png <span style="color: grey">(120c7b2)</span></li>
<li>icons/hi48-app-knights.png <span style="color: grey">(26684f0)</span></li>
<li>icons/hi64-app-knights.png <span style="color: grey">(df75196)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(6d77801)</span></li>
<li>src/board.h <span style="color: grey">(d464bd1)</span></li>
<li>src/board.cpp <span style="color: grey">(775cfd8)</span></li>
<li>src/clock.h <span style="color: grey">(340c885)</span></li>
<li>src/clock.cpp <span style="color: grey">(1e13366)</span></li>
<li>src/clockwidget.h <span style="color: grey">(5686a95)</span></li>
<li>src/clockwidget.cpp <span style="color: grey">(2a4e744)</span></li>
<li>src/core/item.cpp <span style="color: grey">(30fe74e)</span></li>
<li>src/core/move.h <span style="color: grey">(50e32b0)</span></li>
<li>src/core/move.cpp <span style="color: grey">(4f7ca0e)</span></li>
<li>src/core/piece.cpp <span style="color: grey">(4564ae8)</span></li>
<li>src/core/pos.h <span style="color: grey">(343a8b5)</span></li>
<li>src/core/pos.cpp <span style="color: grey">(8623c27)</span></li>
<li>src/customdifficultydialog.ui <span style="color: grey">(f9f7b29)</span></li>
<li>src/enginesettings.h <span style="color: grey">(2942ad1)</span></li>
<li>src/enginesettings.cpp <span style="color: grey">(4802ce0)</span></li>
<li>src/enginesettings.ui <span style="color: grey">(eb59af2)</span></li>
<li>src/externalcontrol.h <span style="color: grey">(40dbf55)</span></li>
<li>src/externalcontrol.cpp <span style="color: grey">(1467491)</span></li>
<li>src/gamedialog.h <span style="color: grey">(5518290)</span></li>
<li>src/gamedialog.cpp <span style="color: grey">(2d0a124)</span></li>
<li>src/gamedialog.ui <span style="color: grey">(436887d)</span></li>
<li>src/gamemanager.h <span style="color: grey">(fe7f883)</span></li>
<li>src/gamemanager.cpp <span style="color: grey">(c9d9566)</span></li>
<li>src/historywidget.h <span style="color: grey">(0d9f823)</span></li>
<li>src/historywidget.cpp <span style="color: grey">(9f7f3fd)</span></li>
<li>src/historywidget.ui <span style="color: grey">(aacc0be)</span></li>
<li>src/knights.cpp <span style="color: grey">(cb688a7)</span></li>
<li>src/knights.desktop <span style="color: grey">(400cf57)</span></li>
<li>src/knightsdebug.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/knightsview.h <span style="color: grey">(40df529)</span></li>
<li>src/knightsview.cpp <span style="color: grey">(5451eb9)</span></li>
<li>src/main.cpp <span style="color: grey">(504fcc5)</span></li>
<li>src/offerwidget.cpp <span style="color: grey">(0993ae2)</span></li>
<li>src/org.kde.knights.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/popup.ui <span style="color: grey">(d4665af)</span></li>
<li>src/promotiondialog.ui <span style="color: grey">(810e67d)</span></li>
<li>src/proto/chatwidget.h <span style="color: grey">(4afcdf6)</span></li>
<li>src/proto/chatwidget.cpp <span style="color: grey">(fa209f9)</span></li>
<li>src/proto/chatwidget.ui <span style="color: grey">(82ff8b7)</span></li>
<li>src/proto/computerprotocol.cpp <span style="color: grey">(a0b032f)</span></li>
<li>src/proto/ficsdialog.h <span style="color: grey">(93d5564)</span></li>
<li>src/proto/ficsdialog.cpp <span style="color: grey">(d89a07c)</span></li>
<li>src/proto/ficsdialog.ui <span style="color: grey">(8eea2e7)</span></li>
<li>src/proto/ficsprotocol.h <span style="color: grey">(3d3e395)</span></li>
<li>src/proto/ficsprotocol.cpp <span style="color: grey">(2c9b07d)</span></li>
<li>src/proto/localprotocol.cpp <span style="color: grey">(711ec5c)</span></li>
<li>src/proto/protocol.cpp <span style="color: grey">(e489d33)</span></li>
<li>src/proto/seekgraph.h <span style="color: grey">(cba3b5f)</span></li>
<li>src/proto/seekgraph.cpp <span style="color: grey">(3c83591)</span></li>
<li>src/proto/textprotocol.h <span style="color: grey">(8216f24)</span></li>
<li>src/proto/textprotocol.cpp <span style="color: grey">(d6f5290)</span></li>
<li>src/proto/uciprotocol.cpp <span style="color: grey">(69d7efb)</span></li>
<li>src/proto/xboardprotocol.cpp <span style="color: grey">(01fb4ae)</span></li>
<li>src/rules/chessrules.cpp <span style="color: grey">(3e993e4)</span></li>
<li>src/rules/rules.h <span style="color: grey">(032cde4)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126124/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>