<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125906/">https://git.reviewboard.kde.org/r/125906/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On November 1st, 2015, 8:40 nachm. UTC, <b>Laurent Montel</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/125906/diff/1/?file=413928#file413928line35" style="color: black; font-weight: bold; text-decoration: underline;">src/namedialog.ui</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">35</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <widget class="<span class="hl">Q</span>LineEdit" name="editPlayer2" /></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">35</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <widget class="<span class="hl">K</span>LineEdit" name="editPlayer2" /></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">why ?
We try to use QLineEdit unless there is a missing feature.
So what is the missing feature here ?</p></pre>
</blockquote>
<p>On November 1st, 2015, 8:50 nachm. UTC, <b>Frederik Schwarzer</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Just for reference:
https://community.kde.org/Frameworks/Porting_Notes#General_2
Second bullet point.</p></pre>
</blockquote>
<p>On November 1st, 2015, 8:56 nachm. UTC, <b>Laurent Montel</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ok but as I reformulate my question. Why now it's necessary ?
Ok I know that klineedit support completion but why now it needs it ?</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The only real reason for the change is the fact that krazy complains about using QLineEdit ("... make sure to use the KDE version of some Qt GUI elements to provide a consistent look and feel for the KDE desktop.")</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">If this is against KDE policies, krazy probably needs some adjustment.</p></pre>
<br />
<p>- Martin</p>
<br />
<p>On November 1st, 2015, 9:56 vorm. UTC, Martin Walch wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Games.</div>
<div>By Martin Walch.</div>
<p style="color: grey;"><i>Updated Nov. 1, 2015, 9:56 vorm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
lskat
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Fix warnings:</p>
<ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">explicit constructors</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">use KLineEdit instead of QLineEdit</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">naming convention of include guards</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">allocate dialogs on the heap and hold them in QPointers</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">add newline at EOF</li>
</ul>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Update website in README and main.cpp</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Clean up lskat.lsm</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Fix lots of typos</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Fix some issues in API documentation</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Clean up some whitespace</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Most obvious changes are probably the updated URL in >Help >About LSkat and the use of KLineEdit instead of QLineEdit in the dialog for changing the player names.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Compiled on KF5.
Started and played some rounds, no obvious downsides encountered.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>README <span style="color: grey">(d6131309dfd7d2dc6bd60dad15c089d51c6184c0)</span></li>
<li>lskat.lsm <span style="color: grey">(bd90d94eb9a38625ee9de2c5bd5c95ccec4c29a6)</span></li>
<li>src/abstractdisplay.h <span style="color: grey">(5c25f9e1dc0391c0863619c6819d641911f073ee)</span></li>
<li>src/abstractdisplay.cpp <span style="color: grey">(e8a8f1266af1ce20be6ad5de931b1cdce037c9bf)</span></li>
<li>src/abstractengine.h <span style="color: grey">(e6aae39027ca6c6ca917f53881d80780f1d6a23f)</span></li>
<li>src/abstractengine.cpp <span style="color: grey">(7abc3ca665014394f1f3694231085b310bf6f751)</span></li>
<li>src/abstractinput.h <span style="color: grey">(d1d831ad0455ffa90bb805d1e18477bb205f0cbd)</span></li>
<li>src/abstractinput.cpp <span style="color: grey">(53df16db5bc84fce5dbfc0a7f474f69963ea8e84)</span></li>
<li>src/aiinput.h <span style="color: grey">(a9aac3a2bd54e3ee3a493ecdc48d3678f20b94c8)</span></li>
<li>src/aiinput.cpp <span style="color: grey">(e8d6865026a8ef94041b44d92717b3f882b2c96a)</span></li>
<li>src/cardsprite.h <span style="color: grey">(074fab9abbbaf7312f916b7606e052753b4d2514)</span></li>
<li>src/cardsprite.cpp <span style="color: grey">(a2e23c66344206861f0527985f9bffa5e9a99b2d)</span></li>
<li>src/config-src.h.cmake <span style="color: grey">(2375fd30d6de1ab735a4c1ad94774ccf403d7339)</span></li>
<li>src/config_two.h <span style="color: grey">(7e7b256a1ff580dd9c9948dceeb28310e3d3867c)</span></li>
<li>src/config_two.cpp <span style="color: grey">(6ed225a62b93c6c1f55f0489feae2bcb85877935)</span></li>
<li>src/deck.h <span style="color: grey">(68a1d927315b127c7f3bfaf15278dd5c7b09fc17)</span></li>
<li>src/deck.cpp <span style="color: grey">(9af9ff570c8347d910ca78e3942fec9259b93f09)</span></li>
<li>src/display_intro.h <span style="color: grey">(45d93a61b4d29452036c4a0e7d798043719854f7)</span></li>
<li>src/engine_two.h <span style="color: grey">(aba52c01142cd2d4995fdc6162872a9ed2b8e3c2)</span></li>
<li>src/engine_two.cpp <span style="color: grey">(579e23a6d48d7496e06667b13564276de11f3cb1)</span></li>
<li>src/fromlibkdegames/cardcache.h <span style="color: grey">(8d5f99e7c0983bd7da510b4c2e0e16d60df67cd6)</span></li>
<li>src/fromlibkdegames/cardcache.cpp <span style="color: grey">(ec6e78c0fd521722e66b44a76514302493b7f861)</span></li>
<li>src/fromlibkdegames/cardcache_p.h <span style="color: grey">(effd6180c5104af6276e6e8e84e43dfac11b0be4)</span></li>
<li>src/fromlibkdegames/carddeckinfo.h <span style="color: grey">(57cd7b530e7192e9b016539b83098e491437da2d)</span></li>
<li>src/fromlibkdegames/carddeckinfo.cpp <span style="color: grey">(d9e584b19ee5c8e93341d56b3398c722544810ef)</span></li>
<li>src/fromlibkdegames/carddeckinfo_p.h <span style="color: grey">(70df1bffe3b32ff4cf772ee5f22731bef27a22c4)</span></li>
<li>src/fromlibkdegames/kcarddialog.h <span style="color: grey">(040fd9d8a59f22890207b6a1b64778edc663d8e0)</span></li>
<li>src/gameview.h <span style="color: grey">(d052b010f267ef9ba9896b62cb19fc1038cd823d)</span></li>
<li>src/gameview.cpp <span style="color: grey">(11fc524d83cbfe40a580fcb63d27c4db19c8a655)</span></li>
<li>src/lskatglobal.h <span style="color: grey">(0c06da022a1053d1b55e7aa652cf1480a53676fc)</span></li>
<li>src/lskatui.rc <span style="color: grey">(4132ff86c4b823405ecbe903ed51d060a1fed7a9)</span></li>
<li>src/main.cpp <span style="color: grey">(51afdc7b6bfa00bda81dc7bfe3416570c02ce756)</span></li>
<li>src/mainwindow.h <span style="color: grey">(e516498b27be7fb2041da4c0db43edfdf111fd72)</span></li>
<li>src/mainwindow.cpp <span style="color: grey">(82a11ca6d4e29396b74d2927faa717d9aa4a8e8b)</span></li>
<li>src/mouseinput.h <span style="color: grey">(3c15cc3c452963a186f5e0a5dbc3663d743e1fbd)</span></li>
<li>src/mouseinput.cpp <span style="color: grey">(70988a6ab163ae3498dd3e44088fb6f62375a653)</span></li>
<li>src/namedialog.ui <span style="color: grey">(681d76c896572c6973645d89104647ea7a0847c1)</span></li>
<li>src/namedialogwidget.h <span style="color: grey">(9a05f0e25ec424fe7a7ba3c79405e766ce2d59c7)</span></li>
<li>src/pixmapsprite.h <span style="color: grey">(979fd8b923452be0bbb649e4ebd761da8957779c)</span></li>
<li>src/pixmapsprite.cpp <span style="color: grey">(ee0e09f182eb48808b328915f0f1ace2f7ff8f15)</span></li>
<li>src/player.cpp <span style="color: grey">(f34f6d74b6a066b2553e9c816bab8600c337be5d)</span></li>
<li>src/scoresprite.h <span style="color: grey">(b14fdc90223d895df3389a6c859578009688bbbc)</span></li>
<li>src/scoresprite.cpp <span style="color: grey">(2b0be3136bb5c2abfd857d36bd47c54778826388)</span></li>
<li>src/textsprite.h <span style="color: grey">(15cf431fd2aec239a31a9bc261900dd8a913afbd)</span></li>
<li>src/textsprite.cpp <span style="color: grey">(55d981906b6bdcb0e0845891e89553ae77ca1526)</span></li>
<li>src/thememanager.cpp <span style="color: grey">(74caf04f7ee6c0a9383fcfbacb41bb57f472eee4)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125906/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>