<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124178/">https://git.reviewboard.kde.org/r/124178/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On June 26th, 2015, 4:19 a.m. MDT, <b>Laurent Montel</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/124178/diff/1/?file=381356#file381356line22" style="color: black; font-weight: bold; text-decoration: underline;">src/gui/selectboardwindow.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">22</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp">#include <<span class="hl">KL</span>ocalized<span class="hl">S</span>tring></span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">22</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp">#include <<span class="hl">kl</span>ocalized<span class="hl">s</span>tring<span class="hl">.h</span>></span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Wierd because I use it in all project and KLocalizedString is found directly when we add KF5::I18n</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Yes that was the problem picmi didn't have KF5::I18n in it's find_package call before. Adding that made this change unneccessary as you say.</p></pre>
<br />
<p>- Jeremy</p>
<br />
<p>On June 25th, 2015, 7:27 a.m. MDT, Jakob Gruber wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Games.</div>
<div>By Jakob Gruber.</div>
<p style="color: grey;"><i>Updated June 25, 2015, 7:27 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
picmi
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This results in errors at compile time:
/usr/bin/ld: cannot find -lKF5::KIOWidgets
/usr/bin/ld: cannot find -lKF5::KDELibs4Support
/usr/bin/ld: cannot find -lKF5::KDELibs4Support</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(c9c31e4a14ec63e55c3da8aedd6df325c676d1fc)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(a2fdd59780deafd5fa42c8095ba419ed8ee4f034)</span></li>
<li>src/gui/CMakeLists.txt <span style="color: grey">(43d75ed1633cfb7b5b4b23ed7ffa187e0c45062d)</span></li>
<li>src/gui/graphicsitems/pixmapitem.cpp <span style="color: grey">(c455073d8457fef6b4de855a4c950c98bbd49f29)</span></li>
<li>src/gui/selectboardwindow.cpp <span style="color: grey">(44f89ee612275a934a9153cb37f1346d35bb5792)</span></li>
<li>src/logic/CMakeLists.txt <span style="color: grey">(0433665c06fea2c7c59b9908250ab7415b9274da)</span></li>
<li>src/logic/levelloader.cpp <span style="color: grey">(2abad5e3e7e26b7a5e3adb34bf7ef0ab0f878ae8)</span></li>
<li>src/main.cpp <span style="color: grey">(943854f810eeef9483684a7f597fa9186aeafe3e)</span></li>
<li>test/logic/CMakeLists.txt <span style="color: grey">(7dce7e71edd35e47ba8706a2fc44b0756857c52f)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124178/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>