<div dir="ltr"><div>Hi,<br><br></div><div>Viranch tells me he is no longer maintaining this game. Is someone else interested in reviewing my patch, or can I just request git push rights and push it to master myself?<br><br></div><div>Thanks,<br></div><div>Peter<br><br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Sun, May 31, 2015 at 7:51 AM, Peter Nowee <span dir="ltr"><<a href="mailto:peter.nowee+kde@gmail.com" target="_blank">peter.nowee+kde@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div>
<div style="font-family:Verdana,Arial,Helvetica,Sans-Serif">
<table style="border:1px #c9c399 solid;border-radius:6px" bgcolor="#f9f3c9" cellpadding="12" width="100%">
<tbody><tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123950/" target="_blank">https://git.reviewboard.kde.org/r/123950/</a>
</td>
</tr>
</tbody></table>
<br>
<table style="border:1px #888a85 solid;border-radius:6px" bgcolor="#fefadf" cellpadding="12" cellspacing="0" width="100%">
<tbody><tr>
<td>
<div>Review request for KDE Games and Viranch Mehta.</div>
<div>By Peter Nowee.</div>
<div style="margin-top:1.5em">
<b style="color:#575012;font-size:10pt;margin-top:1.5em">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=165171" target="_blank">165171</a>
</div>
<div style="margin-top:1.5em">
<b style="color:#575012;font-size:10pt">Repository: </b>
kbreakout
</div>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Description </h1>
<table style="border:1px solid #b8b5a0" bgcolor="#ffffff" cellpadding="10" cellspacing="0" width="100%">
<tbody><tr>
<td>
<pre style="margin:0;padding:0;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word"><p style="padding:0;margin:0;line-height:inherit;white-space:inherit">Restore debugging/cheat codes</p>
<p style="padding:0;margin:0;line-height:inherit;white-space:inherit">This changeset restores the debugging/cheat codes that were left out
of the QtQuick port (version 4.9.90, commits 5043da7 and f8f3491):</p>
<ul style="padding:0;margin:0 0 0 1em;line-height:inherit;white-space:normal">
<li style="padding:0;margin:0;line-height:inherit;white-space:normal">S = Skip level</li>
<li style="padding:0;margin:0;line-height:inherit;white-space:normal">L = Add life</li>
</ul>
<p style="padding:0;margin:0;line-height:inherit;white-space:inherit">These cheat codes are invaluable when designing and testing levels,
as my son likes to do.</p>
<p style="padding:0;margin:0;line-height:inherit;white-space:inherit">Like before, all this will only be available when the KDE_DEBUG
environment variable is true, for example:</p>
<p style="padding:0;margin:0;line-height:inherit;white-space:inherit"></p><div style="background:#f8f8f8"><pre style="line-height:125%">KDE_DEBUG=1 kbreakout
</pre></div>
<p></p>
<p style="padding:0;margin:0;line-height:inherit;white-space:inherit">The key shortcuts (default: "S", "L") can now also be configured
through the menu (provided KDE_DEBUG is true).</p>
<p style="padding:0;margin:0;line-height:inherit;white-space:inherit">CCBUG: 165171</p></pre>
</td>
</tr>
</tbody></table>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Testing </h1>
<table style="border:1px solid #b8b5a0" bgcolor="#ffffff" cellpadding="10" cellspacing="0" width="100%">
<tbody><tr>
<td>
<pre style="margin:0;padding:0;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word"><p style="padding:0;margin:0;line-height:inherit;white-space:inherit">Successfully built using:</p>
<ul style="padding:0;margin:0 0 0 1em;line-height:inherit;white-space:normal">
<li style="padding:0;margin:0;line-height:inherit;white-space:normal">current master of kbreakout (commit 4ad76c6)</li>
<li style="padding:0;margin:0;line-height:inherit;white-space:normal">libkdegames 15.04.1</li>
</ul>
<p style="padding:0;margin:0;line-height:inherit;white-space:inherit">Tested functionality. Everything seems to work as expected.</p>
<p style="padding:0;margin:0;line-height:inherit;white-space:inherit">Tested that without KDE_DEBUG set to true, the cheat keys do not work
and do not show up in Configure Shortcuts.</p></pre>
</td>
</tr>
</tbody></table>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Diffs </h1>
<ul style="margin-left:3em;padding-left:0">
<li>src/canvaswidget.h <span style="color:grey">(c3ae6a6e5b4119ab6c77bb04fe67863cbe7294cc)</span></li>
<li>src/canvaswidget.cpp <span style="color:grey">(341aa16cb573931067d2c7f80be14502c34d23d8)</span></li>
<li>src/mainwindow.h <span style="color:grey">(a371b4bae1f5b0ecbd9be7055694644dfdb69127)</span></li>
<li>src/mainwindow.cpp <span style="color:grey">(c3291a01fa79829d43a0b9e910708f1cfb7df3ac)</span></li>
<li>src/qml/logic.js <span style="color:grey">(c43d0d46ceda523d0e7a14d8ba8bd8b4b73c9767)</span></li>
<li>src/qml/main.qml <span style="color:grey">(d681ad3b15dcf8a67e873591457b36fe1f58a720)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123950/diff/" style="margin-left:3em" target="_blank">View Diff</a></p>
</td>
</tr>
</tbody></table>
</div>
</div>
</blockquote></div><br></div>