<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121589/">https://git.reviewboard.kde.org/r/121589/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/121589/diff/2/?file=350159#file350159line29" style="color: black; font-weight: bold; text-decoration: underline;">CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">29</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span class="s">tron.cpp</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">29</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span class="s">tron.cpp</span></pre></td>
</tr>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">30</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span class="s">ktron.cpp</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">30</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span class="s">ktron.cpp</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Should these files be renamed?</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/121589/diff/2/?file=350159#file350159line37" style="color: black; font-weight: bold; text-decoration: underline;">CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">37</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="err">kde4_add_app_icon(k<span class="hl">tron</span>_SRCS</span> <span class="err">"${CMAKE_CURRENT_SOURCE_DIR}/pics/hi*-app-ktron.png")</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">37</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="err">kde4_add_app_icon(k<span class="hl">snakeduel</span>_SRCS</span> <span class="err">"${CMAKE_CURRENT_SOURCE_DIR}/pics/hi*-app-ktron.png")</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Name still contains ktron.</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/121589/diff/2/?file=350159#file350159line51" style="color: black; font-weight: bold; text-decoration: underline;">CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">51</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">install</span><span class="p">(</span><span class="s">FILES</span> <span class="s">k<span class="hl">tron.kcfg</span></span> <span class="s">DESTINATION</span> <span class="o">${</span><span class="nv"><span class="hl">KCFG</span>_INSTALL_DIR</span><span class="o">}</span><span class="p">)</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">49</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">install</span><span class="p">(</span><span class="s">FILES</span> <span class="s">k<span class="hl">snakeduelui.rc</span></span> <span class="s">DESTINATION</span> <span class="o">${</span><span class="nv"><span class="hl">DATA</span>_INSTALL_DIR</span><span class="o">}</span><span class="s"><span class="hl">/ktron</span></span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Still contains ktron.</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/121589/diff/2/?file=350165#file350165line2" style="color: black; font-weight: bold; text-decoration: underline;">ksnakeduel.knsrc</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">2</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">ProvidersUrl=http://newstuff.kde.org/cgi-bin/hotstuff-provider?site=ktron</pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">There aeem to be still quite a few ktron's around. In this one, the link leads to a broken file.</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/121589/diff/2/?file=350166#file350166line2" style="color: black; font-weight: bold; text-decoration: underline;">ksnakeduelui.rc</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">2</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="o"><</span><span class="n">gui</span> <span class="n">name</span><span class="o">=</span><span class="s">"ktron"</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Uses ktron name.</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/121589/diff/2/?file=350171#file350171line45" style="color: black; font-weight: bold; text-decoration: underline;">main.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">static KLocalizedString notice = ki18n("(c) 1998-2000, Matthias Kiefer\n"</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">45</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">KTRON_VERSION</span><span class="p">,</span> <span class="n">description</span><span class="p">,</span> <span class="n">KAboutData</span><span class="o">::</span><span class="n">License_GPL</span><span class="p">,</span> <span class="n">notice</span><span class="p">);</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">45</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">KTRON_VERSION</span><span class="p">,</span> <span class="n">description</span><span class="p">,</span> <span class="n">KAboutData</span><span class="o">::</span><span class="n">License_GPL</span><span class="p">,</span> <span class="n">notice</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Contains name KTRON.</p></pre>
</div>
</div>
<br />
<p>- Ian Wadham</p>
<br />
<p>On February 19th, 2015, 2:22 p.m. UTC, Jonathan Riddell wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Games.</div>
<div>By Jonathan Riddell.</div>
<p style="color: grey;"><i>Updated Feb. 19, 2015, 2:22 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ksnakeduel
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">For some reason ksnakeduel has three names. This gets rid of one of them, ktron and changes it to ksnakeduel. This was mostly done already but this changes the binary name too which was causing confusion to us little packagers.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I also think the kdesnake script and .desktop file should go away, you can set it in the UI.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">compile, install and run</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(49616d7)</span></li>
<li>pics/hi32-app-kdesnake.png <span style="color: grey">(27b133b)</span></li>
<li>pics/hi32-app-ksnakeduel.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>pics/hi32-app-ktron.png <span style="color: grey">(f467683)</span></li>
<li>pics/hi48-app-kdesnake.png <span style="color: grey">(556c9e1)</span></li>
<li>pics/hi48-app-ksnakeduel.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>pics/hi48-app-ktron.png <span style="color: grey">(ac857f9)</span></li>
<li>pics/hi64-app-kdesnake.png <span style="color: grey">(e9d7ebe)</span></li>
<li>pics/hi64-app-ksnakeduel.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>pics/hi64-app-ktron.png <span style="color: grey">(a79a401)</span></li>
<li>settings.kcfgc <span style="color: grey">(8450b7d)</span></li>
<li>themes/CMakeLists.txt <span style="color: grey">(aad7fed)</span></li>
<li>doc/CMakeLists.txt <span style="color: grey">(99fed14)</span></li>
<li>kdesnake.cmake <span style="color: grey">(0a4e46d)</span></li>
<li>kdesnake.desktop <span style="color: grey">(5e49105)</span></li>
<li>ksnakeduel.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>ksnakeduel.kcfg <span style="color: grey">(PRE-CREATION)</span></li>
<li>ksnakeduel.knsrc <span style="color: grey">(PRE-CREATION)</span></li>
<li>ksnakeduelui.rc <span style="color: grey">(PRE-CREATION)</span></li>
<li>ktron.desktop <span style="color: grey">(3b2e386)</span></li>
<li>ktron.kcfg <span style="color: grey">(ab764b9)</span></li>
<li>ktron.knsrc <span style="color: grey">(9cc0835)</span></li>
<li>ktronui.rc <span style="color: grey">(baab667)</span></li>
<li>main.cpp <span style="color: grey">(79fb05f)</span></li>
<li>pics/hi128-app-kdesnake.png <span style="color: grey">(797a458)</span></li>
<li>pics/hi128-app-ksnakeduel.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>pics/hi128-app-ktron.png <span style="color: grey">(73da488)</span></li>
<li>pics/hi16-app-kdesnake.png <span style="color: grey">(de8f38a)</span></li>
<li>pics/hi16-app-ksnakeduel.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>pics/hi16-app-ktron.png <span style="color: grey">(0928dbf)</span></li>
<li>pics/hi22-app-kdesnake.png <span style="color: grey">(1b7948b)</span></li>
<li>pics/hi22-app-ksnakeduel.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>pics/hi22-app-ktron.png <span style="color: grey">(e2206df)</span></li>
<li>pics/hi256-app-kdesnake.png <span style="color: grey">(270a652)</span></li>
<li>pics/hi256-app-ksnakeduel.png <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121589/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>