<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120297/">https://git.reviewboard.kde.org/r/120297/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Games, Ian Wadham and Raymond Wooninck.</div>
<div>By Marko Käning.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
bovo
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Errors like this break bovo's build on OSX and Linux</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%"> <span style="color: #666666">/</span>Users<span style="color: #666666">/</span>marko<span style="color: #666666">/</span>WC<span style="color: #666666">/</span>KDECI<span style="color: #666666">-</span>builds<span style="color: #666666">/</span>bovo<span style="color: #666666">/</span>ai<span style="color: #666666">/</span>aron<span style="color: #666666">/</span>aiboard.cc<span style="color: #666666">:450:11:</span> error<span style="color: #666666">:</span> non<span style="color: #666666">-</span>constant<span style="color: #666666">-</span>expression cannot
be narrowed from type <span style="border: 1px solid #FF0000">'</span><span style="color: #B00040">int</span><span style="border: 1px solid #FF0000">'</span> to <span style="border: 1px solid #FF0000">'</span>usi<span style="border: 1px solid #FF0000">'</span> (aka <span style="border: 1px solid #FF0000">'</span><span style="color: #B00040">unsigned</span> <span style="color: #B00040">short</span><span style="border: 1px solid #FF0000">'</span>) in initializer list [<span style="color: #666666">-</span>Wc<span style="color: #666666">++11-</span>narrowing]
LEFT <span style="color: #666666">|</span> UP,
<span style="color: #666666">^~~~~~~~~</span>
</pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">due to non-constant expressions being generated by the compiler.</p>
<hr style="text-rendering: inherit;margin: 0;padding: 0;white-space: normal;border: 1px solid #ddd;line-height: inherit;" />
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Still, this patch alone doesn't look nice. I think re-defining those constants FOUR times should be avoided. </p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Builds fine with this patch applied.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>ai/aron/aiboard.cc <span style="color: grey">(91d8192)</span></li>
<li>game/game.cc <span style="color: grey">(c000a89)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120297/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>