<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120288/">https://git.reviewboard.kde.org/r/120288/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">shipt it from me on the CMake part... i'd wait for Albert's word on actual code changes.</p></pre>
<br />
<p>- Hrvoje Senjan</p>
<br />
<p>On September 19th, 2014, 10:49 p.m. CEST, Raymond Wooninck wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Games, Albert Astals Cid and Hrvoje Senjan.</div>
<div>By Raymond Wooninck.</div>
<p style="color: grey;"><i>Updated Sept. 19, 2014, 10:49 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
libkmahjongg
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Initial port to Frameworks. This would mean that a new branch Frameworks is created for this library where we can work further on it</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Library compiles without deprecated warnings and errors. Functionality can only be tested once kmahjongg itself is ported (which would be the next step)</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(8db109d)</span></li>
<li>KF5KMahjongglibConfig.cmake.in <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmahjonggbackground.cpp <span style="color: grey">(c63968f)</span></li>
<li>kmahjonggbackgroundselector.cpp <span style="color: grey">(1ed407f)</span></li>
<li>kmahjonggconfigdialog.h <span style="color: grey">(ed27f41)</span></li>
<li>kmahjonggconfigdialog.cpp <span style="color: grey">(c90fefd)</span></li>
<li>kmahjonggtileset.cpp <span style="color: grey">(938e292)</span></li>
<li>kmahjonggtilesetselector.cpp <span style="color: grey">(6e32867)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120288/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>