<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120193/">https://git.reviewboard.kde.org/r/120193/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 14th, 2014, 6:42 p.m. CEST, <b>Marko Käning</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Hi guys,</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">this is what I see on the OSX/CI using this patch:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%">Linking CXX executable kgamepropertytest.app<span style="color: #666666">/</span>Contents<span style="color: #666666">/</span>MacOS<span style="color: #666666">/</span>kgamepropertytest
<span style="color: #A0A000">ld:</span> library not found <span style="color: #008000; font-weight: bold">for</span> <span style="color: #666666">-</span>lkdegamesprivate
<span style="color: #A0A000">clang:</span> error<span style="color: #666666">:</span> linker command failed with exit code <span style="color: #666666">1</span> (use <span style="color: #666666">-</span>v to see invocation)
make[<span style="color: #666666">2</span>]<span style="color: #666666">:</span> <span style="color: #666666">***</span> [libkdegamesprivate<span style="color: #666666">/</span>tests<span style="color: #666666">/</span>kgamepropertytest.app<span style="color: #666666">/</span>Contents<span style="color: #666666">/</span>MacOS<span style="color: #666666">/</span>kgamepropertytest] Error <span style="color: #666666">1</span>
make[<span style="color: #666666">1</span>]<span style="color: #666666">:</span> <span style="color: #666666">***</span> [libkdegamesprivate<span style="color: #666666">/</span>tests<span style="color: #666666">/</span>CMakeFiles<span style="color: #666666">/</span>kgamepropertytest.dir<span style="color: #666666">/</span>all] Error <span style="color: #666666">2</span>
make[<span style="color: #666666">1</span>]<span style="color: #666666">:</span> <span style="color: #666666">***</span> Waiting <span style="color: #008000; font-weight: bold">for</span> unfinished jobs....
Generating moc_kmessageserver.cpp
Generating kplayer.moc
<span style="color: #666666">/</span>Users<span style="color: #666666">/</span>marko<span style="color: #666666">/</span>WC<span style="color: #666666">/</span>KDECI<span style="color: #666666">-</span>builds<span style="color: #666666">/</span>libkdegames<span style="color: #666666">/</span>libkdegamesprivate<span style="color: #666666">/</span>kgame<span style="color: #666666">/</span>kplayer.cpp<span style="color: #666666">:0:</span> Note<span style="color: #666666">:</span> No relevant classes found. No output generated.
Generating moc_kgamerenderer.cpp
Generating moc_kgamerenderer_p.cpp
Generating kgdeclarativeview.moc
<span style="color: #666666">/</span>Users<span style="color: #666666">/</span>marko<span style="color: #666666">/</span>WC<span style="color: #666666">/</span>KDECI<span style="color: #666666">-</span>builds<span style="color: #666666">/</span>libkdegames<span style="color: #666666">/</span>kgdeclarativeview.cpp<span style="color: #666666">:0:</span> Note<span style="color: #666666">:</span> No relevant classes found. No output generated.
Generating kgamecanvas.moc
<span style="color: #666666">/</span>Users<span style="color: #666666">/</span>marko<span style="color: #666666">/</span>WC<span style="color: #666666">/</span>KDECI<span style="color: #666666">-</span>builds<span style="color: #666666">/</span>libkdegames<span style="color: #666666">/</span>libkdegamesprivate<span style="color: #666666">/</span>kgamecanvas.cpp<span style="color: #666666">:0:</span> Note<span style="color: #666666">:</span> No relevant classes found. No output generated.
Linking CXX executable kgamesvgdocumenttest.app<span style="color: #666666">/</span>Contents<span style="color: #666666">/</span>MacOS<span style="color: #666666">/</span>kgamesvgdocumenttest
<span style="color: #A0A000">ld:</span> library not found <span style="color: #008000; font-weight: bold">for</span> <span style="color: #666666">-</span>lkdegamesprivate
<span style="color: #A0A000">clang:</span> error<span style="color: #666666">:</span> linker command failed with exit code <span style="color: #666666">1</span> (use <span style="color: #666666">-</span>v to see invocation)
make[<span style="color: #666666">2</span>]<span style="color: #666666">:</span> <span style="color: #666666">***</span> [libkdegamesprivate<span style="color: #666666">/</span>tests<span style="color: #666666">/</span>kgamesvgdocumenttest.app<span style="color: #666666">/</span>Contents<span style="color: #666666">/</span>MacOS<span style="color: #666666">/</span>kgamesvgdocumenttest] Error <span style="color: #666666">1</span>
make[<span style="color: #666666">1</span>]<span style="color: #666666">:</span> <span style="color: #666666">***</span> [libkdegamesprivate<span style="color: #666666">/</span>tests<span style="color: #666666">/</span>CMakeFiles<span style="color: #666666">/</span>kgamesvgdocumenttest.dir<span style="color: #666666">/</span>all] Error <span style="color: #666666">2</span>
Generating kgdifficulty.moc
</pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Greets, Marko</p></pre>
</blockquote>
<p>On September 15th, 2014, 1:25 p.m. CEST, <b>Raymond Wooninck</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Found the cause of this failure and have adjusted it in the new version</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Hi Raymond, this is what I get now:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%">[ <span style="color: #666666">31%</span>] [ <span style="color: #666666">32%</span>] Building CXX object CMakeFiles<span style="color: #666666">/</span>KF5KDEGames.dir<span style="color: #666666">/</span>kgamerendereditem.cpp.o
Building CXX object CMakeFiles<span style="color: #666666">/</span>KF5KDEGames.dir<span style="color: #666666">/</span>kgamerenderedobjectitem.cpp.o
<span style="color: #666666">/</span>Users<span style="color: #666666">/</span>marko<span style="color: #666666">/</span>WC<span style="color: #666666">/</span>KDECI<span style="color: #666666">-</span>builds<span style="color: #666666">/</span>libkdegames<span style="color: #666666">/</span>highscore<span style="color: #666666">/</span>khighscore.cpp<span style="color: #666666">:166:9:</span> error<span style="color: #666666">:</span> incomplete type <span style="border: 1px solid #FF0000">'</span>KSharedConfig<span style="border: 1px solid #FF0000">'</span> named in nested name specifier
KSharedConfig<span style="color: #666666">::</span>openConfig()<span style="color: #666666">-></span>sync();
<span style="color: #666666">^~~~~~~~~~~~~~~</span>
<span style="color: #666666">/</span>opt<span style="color: #666666">/</span>kde<span style="color: #666666">/</span>install<span style="color: #666666">/</span>darwin<span style="color: #666666">/</span>mavericks<span style="color: #666666">/</span>clang<span style="color: #666666">/</span>kf5<span style="color: #666666">-</span>qt5<span style="color: #666666">/</span>frameworks<span style="color: #666666">/</span>kconfig<span style="color: #666666">/</span>inst<span style="color: #666666">/</span>include<span style="color: #666666">/</span>KF5<span style="color: #666666">/</span>KConfigCore<span style="color: #666666">/</span>kconfig.h<span style="color: #666666">:370:18:</span> note<span style="color: #666666">:</span> forward declaration of <span style="border: 1px solid #FF0000">'</span>KSharedConfig<span style="border: 1px solid #FF0000">'</span>
friend class KSharedConfig;
<span style="color: #666666">^</span>
<span style="color: #666666">/</span>Users<span style="color: #666666">/</span>marko<span style="color: #666666">/</span>WC<span style="color: #666666">/</span>KDECI<span style="color: #666666">-</span>builds<span style="color: #666666">/</span>libkdegames<span style="color: #666666">/</span>highscore<span style="color: #666666">/</span>khighscore.cpp<span style="color: #666666">:184:70:</span> error<span style="color: #666666">:</span> incomplete type <span style="border: 1px solid #FF0000">'</span>KSharedConfig<span style="border: 1px solid #FF0000">'</span> named in nested name specifier
<span style="color: #008000; font-weight: bold">return</span> (d<span style="color: #666666">-></span>global <span style="color: #666666">?</span> lockedConfig<span style="color: #666666">-></span>config <span style="color: #666666">:</span> static_cast<span style="color: #666666"><</span>KConfig<span style="color: #666666">*></span>(KSharedConfig<span style="color: #666666">::</span>openConfig().data()));
<span style="color: #666666">^~~~~~~~~~~~~~~</span>
<span style="color: #666666">/</span>opt<span style="color: #666666">/</span>kde<span style="color: #666666">/</span>install<span style="color: #666666">/</span>darwin<span style="color: #666666">/</span>mavericks<span style="color: #666666">/</span>clang<span style="color: #666666">/</span>kf5<span style="color: #666666">-</span>qt5<span style="color: #666666">/</span>frameworks<span style="color: #666666">/</span>kconfig<span style="color: #666666">/</span>inst<span style="color: #666666">/</span>include<span style="color: #666666">/</span>KF5<span style="color: #666666">/</span>KConfigCore<span style="color: #666666">/</span>kconfig.h<span style="color: #666666">:370:18:</span> note<span style="color: #666666">:</span> forward declaration of <span style="border: 1px solid #FF0000">'</span>KSharedConfig<span style="border: 1px solid #FF0000">'</span>
friend class KSharedConfig;
<span style="color: #666666">^</span>
<span style="color: #666666">2</span> errors generated.
make[<span style="color: #666666">2</span>]<span style="color: #666666">:</span> <span style="color: #666666">***</span> [CMakeFiles<span style="color: #666666">/</span>KF5KDEGames.dir<span style="color: #666666">/</span>highscore<span style="color: #666666">/</span>khighscore.cpp.o] Error <span style="color: #666666">1</span>
make[<span style="color: #666666">2</span>]<span style="color: #666666">:</span> <span style="color: #666666">***</span> Waiting <span style="color: #008000; font-weight: bold">for</span> unfinished jobs....
make[<span style="color: #666666">1</span>]<span style="color: #666666">:</span> <span style="color: #666666">***</span> [CMakeFiles<span style="color: #666666">/</span>KF5KDEGames.dir<span style="color: #666666">/</span>all] Error <span style="color: #666666">2</span>
<span style="color: #A0A000">make:</span> <span style="color: #666666">***</span> [all] Error <span style="color: #666666">2</span>
</pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Greets,<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
Marko</p></pre>
<br />
<p>- Marko</p>
<br />
<p>On September 15th, 2014, 1:26 p.m. CEST, Raymond Wooninck wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Games, Albert Astals Cid, Anuj Pahuja, and David Edmundson.</div>
<div>By Raymond Wooninck.</div>
<p style="color: grey;"><i>Updated Sept. 15, 2014, 1:26 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
libkdegames
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Change the names of the libraries (KF5'ify them) so that they can be co-installed with their KDE4 versions. I assume we can expect that some games will be ported faster than others, so an user might need both libraries installed. With the current setup this is not possible as that they kept the same version and name.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Build libkdegames for KF5 and also build bovo as application against the new libs. Both succeeded </p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>KDEGamesConfig.cmake.in <span style="color: grey">(a875ca0)</span></li>
<li>audio/CMakeLists.txt <span style="color: grey">(7fd582f)</span></li>
<li>CMakeLists.txt <span style="color: grey">(1780889)</span></li>
<li>includes/CMakeLists.txt <span style="color: grey">(378ae37)</span></li>
<li>libkdegamesprivate/CMakeLists.txt <span style="color: grey">(abd5df8)</span></li>
<li>libkdegamesprivate/tests/CMakeLists.txt <span style="color: grey">(27ffbf9)</span></li>
<li>tests/CMakeLists.txt <span style="color: grey">(f5bf4b5)</span></li>
<li>declarativeimports/CMakeLists.txt <span style="color: grey">(c512ce9)</span></li>
<li>highscore/CMakeLists.txt <span style="color: grey">(c28dff9)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120193/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>