<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120169/">https://git.reviewboard.kde.org/r/120169/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I am not the maintainer of KBlocks but all of these changes look completely correct. Good work.</p></pre>
<br />
<p>- Inge Wallin</p>
<br />
<p>On September 12th, 2014, 6:17 p.m. UTC, Martin Walch wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Games.</div>
<div>By Martin Walch.</div>
<p style="color: grey;"><i>Updated Sept. 12, 2014, 6:17 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kblocks
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">krazy2 complains:</p>
<blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;">
<ol style="padding: 0;text-rendering: inherit;margin: 0 0 0 2em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Check for code that should be considered crashy. [crashy]...<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
./KBlocksWin.cpp: line#242 (1)</li>
</ol>
</blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Fix as described in http://blogs.kde.org/node/3919</p>
<blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;">
<ol style="padding: 0;text-rendering: inherit;margin: 0 0 0 2em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Check for C++ ctors that should be declared 'explicit' [explicit]<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
./KBlocksPieceGenerator.h: line#16 (1)<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
./KBlocksGameMessage.h: line#18 (1)<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
./KBlocksGameLogic.h: line#29 (1)<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
./KBlocksAppThread.h: line#19 (1)<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
./KBlocksPiece.h: line#90 (1)<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
./AI/PlannerInterface.h: line#21 (1)<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
./AI/KBlocksAIPlayer.h: line#30 (1)<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
./AI/KBlocksAIPlanner.h: line#24 (1)<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
./AI/KBlocksAIPlannerExtend.h: line#25,51 (2)</li>
</ol>
</blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Fix all by putting "explicit" in front of the constructor, except for KBlocksPiece.h:90, which is sort of a copy constructor (just ignoring it, not suppressing the krazy2 warning).</p>
<blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;">
<ol style="padding: 0;text-rendering: inherit;margin: 0 0 0 2em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Check for proper include directives [includes]...<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
./GamePlayerInterface.h: missing or improper include guard in header</li>
</ol>
</blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">cosmetic change: GAMEPLAYINTERFACE_H -> GAMEPLAYERINTERFACE_H</p>
<blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">./KBlocksConfigManager.cpp: include own header first line#18</p>
</blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Moved up.</p>
<blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">./main.cpp: duplicate includes line#31,38(KBlocksPlayNetwork.h)</p>
</blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Second occurrence removed.</p>
<blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">./KBlocksPieceGenerator.cpp: include own header first line#13</p>
</blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Moved up.</p>
<blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;">
<ol style="padding: 0;text-rendering: inherit;margin: 0 0 0 2em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Check for postfix usage of ++ and -- [postfixop]...<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
./KBlocksNetServer.cpp: line#262 (1)<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
./KBlocksNetPlayer.cpp: line#121 (1)<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
./KBlocksGameRecorder.cpp: line#53,66 (2)</li>
</ol>
</blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Easy fix as all are standalone expressions. So just replace.</p>
<blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;">
<ol style="padding: 0;text-rendering: inherit;margin: 0 0 0 2em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Check for spelling errors [spelling]... 2 issues found<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
./AI/KBlocksAIPlanner.cpp: line#53[coloumn],78[coloumn] (2)<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
Trivial fix as both occurrences are in code comments.</li>
</ol>
</blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">gcc complains at AI/KBlocksAILog.cpp:80:</p>
<blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">warning: ignoring return value of 'int system(const char*)'</p>
</blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This is part of a function "clrscr()". Does not seem to have ever been<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
in use anywhere. Drop that function.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">compiles fine</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">those krazy2 warnings that this patch addresses are gone (and no new warnings introduced)</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">gcc warning about return value is gone</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">runs fine</li>
</ul></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>AI/KBlocksAILog.h <span style="color: grey">(4de71f8)</span></li>
<li>AI/KBlocksAILog.cpp <span style="color: grey">(1988b3f)</span></li>
<li>AI/KBlocksAIPlanner.h <span style="color: grey">(9e72980)</span></li>
<li>AI/KBlocksAIPlanner.cpp <span style="color: grey">(625a868)</span></li>
<li>AI/KBlocksAIPlannerExtend.h <span style="color: grey">(019b57f)</span></li>
<li>AI/KBlocksAIPlayer.h <span style="color: grey">(af7683f)</span></li>
<li>KBlocksPieceGenerator.cpp <span style="color: grey">(736e867)</span></li>
<li>KBlocksWin.cpp <span style="color: grey">(4156ef0)</span></li>
<li>main.cpp <span style="color: grey">(04aae7e)</span></li>
<li>AI/PlannerInterface.h <span style="color: grey">(b3e57be)</span></li>
<li>GamePlayerInterface.h <span style="color: grey">(ebbbe9b)</span></li>
<li>KBlocksAppThread.h <span style="color: grey">(405a7fd)</span></li>
<li>KBlocksConfigManager.cpp <span style="color: grey">(e4d726d)</span></li>
<li>KBlocksGameLogic.h <span style="color: grey">(b63bc43)</span></li>
<li>KBlocksGameMessage.h <span style="color: grey">(bd763d9)</span></li>
<li>KBlocksGameRecorder.cpp <span style="color: grey">(f3a6229)</span></li>
<li>KBlocksNetPlayer.cpp <span style="color: grey">(0bc00f4)</span></li>
<li>KBlocksNetServer.cpp <span style="color: grey">(5842d3c)</span></li>
<li>KBlocksPieceGenerator.h <span style="color: grey">(41da247)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120169/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>