<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120008/">https://git.reviewboard.kde.org/r/120008/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I can't find anything horrible, I think it's good enough if you commit it to the frameworks branch for now unless someone else complains.</p></pre>
<br />
<p>- Albert Astals Cid</p>
<br />
<p>On setembre 3rd, 2014, 4:07 p.m. UTC, Sandro Andrade wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Games.</div>
<div>By Sandro Andrade.</div>
<p style="color: grey;"><i>Updated set. 3, 2014, 4:07 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
bovo
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This patch ports bovo to KF5. It seems the unit test in game/test doesn't build with KDE 4, so it hasn't been ported.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">cmake finds all required KDE 5 frameworks</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">builds ok, with some warning messages</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">bovo themes and icons are correctle installed</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">game functionalities seems work properly</li>
</ul></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>icons/hi48-app-bovo.png <span style="color: grey">(170a4e0e0daed5fa6f48c45483f1305308745ca3)</span></li>
<li>icons/hi48-apps-bovo.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>icons/hi64-app-bovo.png <span style="color: grey">(04d261c727ad0a97696c9068a0eebaf4a11b6de8)</span></li>
<li>icons/hi64-apps-bovo.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>CMakeLists.txt <span style="color: grey">(f8087ef)</span></li>
<li>doc/CMakeLists.txt <span style="color: grey">(166cada)</span></li>
<li>gui/main.cc <span style="color: grey">(b0f89da)</span></li>
<li>gui/mainwindow.h <span style="color: grey">(e0502c6)</span></li>
<li>gui/mainwindow.cc <span style="color: grey">(3fb973f)</span></li>
<li>gui/view.cc <span style="color: grey">(88237c4)</span></li>
<li>icons/CMakeLists.txt <span style="color: grey">(02e3c9e)</span></li>
<li>icons/hi128-app-bovo.png <span style="color: grey">(9f8bec382d8a8c4678192e2c05d192e90386f215)</span></li>
<li>icons/hi128-apps-bovo.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>icons/hi16-app-bovo.png <span style="color: grey">(6a16a316cca0fbd35dcb622a93b19168704a8c08)</span></li>
<li>icons/hi16-apps-bovo.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>icons/hi22-app-bovo.png <span style="color: grey">(4fbc1e1eb6dc274c03b9fe98525d9e6f7d94424d)</span></li>
<li>icons/hi22-apps-bovo.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>icons/hi32-app-bovo.png <span style="color: grey">(708c4ec34b95eb82639ee2f0ff543607fec363bb)</span></li>
<li>icons/hi32-apps-bovo.png <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120008/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>