<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/116483/">https://git.reviewboard.kde.org/r/116483/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 10th, 2014, 1:34 a.m. UTC, <b>Roney Gomes</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/116483/diff/1/?file=251049#file251049line70" style="color: black; font-weight: bold; text-decoration: underline;">src/controller.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">public:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">70</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="kt">void</span> <span class="nf">restartC</span><span class="p">(</span><span class="kt">bool</span> <span class="n">ask</span> <span class="o">=</span> <span class="nb">false</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm not sure what "restartC" means. "Restart Controller" perhaps? If so, considering we're at the controller class already, why not just call it "restart"?</pre>
</blockquote>
<p>On March 10th, 2014, 7:55 a.m. UTC, <b>Jaime Torres Amate</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'll change it, now that it works. I was confused a lot with so many restart() in so many places that I needed to change their name to know what was going on.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">That said, you're free to commit your patch and close this request. Please, do not forget the other issues I also opened.
Ship it!</pre>
<br />
<p>- Roney</p>
<br />
<p>On February 28th, 2014, 4:22 p.m. UTC, Jaime Torres Amate wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Games and Roney Gomes.</div>
<div>By Jaime Torres Amate.</div>
<p style="color: grey;"><i>Updated Feb. 28, 2014, 4:22 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
knavalbattle
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The restart button made the network game use the wrong configuration (it created a new controller), now it uses the current game configuration (and controller). It restarted the chat and sent again the nick, now it is not needed and is not done.
I have introduced, I needed it desperately, the name of the message interchanged as an XML attribute (totally backwards compatible). in protocol.cpp and message.h</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Lots of network games against myself (and some local games against AI too).
Place half the ships to see if it was possible to start to shoot too soon, make one of them unable to finish placing the remaining ships several times, then finish it... waiting for the opposite to finish placing ships. Do the same with the other player.. Start shooting (some times finishing the game), and then press restart. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/controller.h <span style="color: grey">(eb5f63f)</span></li>
<li>src/controller.cpp <span style="color: grey">(3a26170)</span></li>
<li>src/entity.h <span style="color: grey">(c6fcdbc)</span></li>
<li>src/entity.cpp <span style="color: grey">(3104029)</span></li>
<li>src/mainwindow.cpp <span style="color: grey">(7ef4482)</span></li>
<li>src/message.h <span style="color: grey">(58b5beb)</span></li>
<li>src/networkentity.h <span style="color: grey">(aa66543)</span></li>
<li>src/networkentity.cpp <span style="color: grey">(f19b1d5)</span></li>
<li>src/playerentity.cpp <span style="color: grey">(c6b0a1d)</span></li>
<li>src/playfield.h <span style="color: grey">(5766022)</span></li>
<li>src/playfield.cpp <span style="color: grey">(5ebfbc2)</span></li>
<li>src/protocol.cpp <span style="color: grey">(2416164)</span></li>
<li>src/sea.cpp <span style="color: grey">(77a8864)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/116483/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>