<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/116483/">https://git.reviewboard.kde.org/r/116483/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit f2d104200c7a701e65b90d804d0eca714299e628 by Jaime Torres to branch master.</pre>
<br />
<p>- Commit Hook</p>
<br />
<p>On March 10th, 2014, 7:26 p.m. UTC, Jaime Torres Amate wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Games and Roney Gomes.</div>
<div>By Jaime Torres Amate.</div>
<p style="color: grey;"><i>Updated March 10, 2014, 7:26 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
knavalbattle
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The restart button made the network game use the wrong configuration (it created a new controller), now it uses the current game configuration (and controller). It restarted the chat and sent again the nick, now it is not needed and is not done.
I have introduced, I needed it desperately, the name of the message interchanged as an XML attribute (totally backwards compatible). in protocol.cpp and message.h</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Lots of network games against myself (and some local games against AI too).
Place half the ships to see if it was possible to start to shoot too soon, make one of them unable to finish placing the remaining ships several times, then finish it... waiting for the opposite to finish placing ships. Do the same with the other player.. Start shooting (some times finishing the game), and then press restart. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/controller.h <span style="color: grey">(eb5f63f)</span></li>
<li>src/controller.cpp <span style="color: grey">(3a26170)</span></li>
<li>src/entity.h <span style="color: grey">(c6fcdbc)</span></li>
<li>src/entity.cpp <span style="color: grey">(3104029)</span></li>
<li>src/mainwindow.cpp <span style="color: grey">(7ef4482)</span></li>
<li>src/message.h <span style="color: grey">(58b5beb)</span></li>
<li>src/networkentity.h <span style="color: grey">(aa66543)</span></li>
<li>src/networkentity.cpp <span style="color: grey">(f19b1d5)</span></li>
<li>src/playerentity.cpp <span style="color: grey">(c6b0a1d)</span></li>
<li>src/playfield.h <span style="color: grey">(5766022)</span></li>
<li>src/playfield.cpp <span style="color: grey">(5ebfbc2)</span></li>
<li>src/protocol.cpp <span style="color: grey">(2416164)</span></li>
<li>src/sea.cpp <span style="color: grey">(77a8864)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/116483/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>