<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115946/">https://git.reviewboard.kde.org/r/115946/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 22nd, 2014, 11:46 a.m. UTC, <b>Stefan Majewsky</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I just built master and gave it a very quick try.
So I found the new "Move" menu and created a holder, and the first thing that puzzled me (pun not intended) was how to move pieces into the holder. I figured that maybe I could learn the new mouse shortcuts from the configuration dialog, but I found that "Teleport pieces to or from a holder" had no shortcut assigned. Maybe a KConfigUpdate script is in order here to ensure that everyone has whatever the default shortcut is for that one?
After I assigned middle-click to that action, I succeeded to move some pieces to the holder. It was nice how the pieces were arranged in the holder, but I found it awkward that I could not work with the pieces (i.e. combine stuff) while in the holder.
So I tried to get them out of the holder again, but I failed. I tried to middle-click, but it says I cannot do that without another holder. It seems to want to move the pieces to another holder, instead of putting it back on the table.
Overall first impression: The additions look very useful, but I would appreciate some more guidance on how to use it effectively.
Another thing: Inside the holder, you can zoom out far beyond the extent of the shaded constraints. The main puzzle table has some limitation to how far you can zoom out, this would probably be nice for the holders, too.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Oh, another thing: The first page of the configuration dialog looks a bit overcrowded now. At the very least, you should consider splitting the spacing options from "Puzzle table" into a new group box ("Piece arrangement")?
In fact, it might be useful to split the first page into two pages, one for appearance (the color and background options from "Puzzle table", plus the "Piece appearance" groupbox) and one for gameplay.</pre>
<br />
<p>- Stefan</p>
<br />
<p>On February 22nd, 2014, 1:25 a.m. UTC, Ian Wadham wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Games.</div>
<div>By Ian Wadham.</div>
<p style="color: grey;"><i>Updated Feb. 22, 2014, 1:25 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
palapeli
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is NOT a code review.
Rather it is a review of how the new Palapeli works, from a user's point of view, when you are solving a large puzzle (300 to 10,000 pieces). Any suggestions for improvement of the way features work are very welcome.
The complete list of new features is at http://techbase.kde.org/Schedules/KDE4/4.13_Feature_Plan#kdegames and most of them have been pushed to origin master, in preparation for the upcoming freezes of KDE 4.13. You are welcome to review the code on origin master if you wish.
I would appreciate it if people could build the code and just try it out on a large, but not too difficult puzzle, say 300 to 500 pieces.
To support solving large puzzles there are some items in the new Move and View menus and some new settings in both Settings dialog pages.
Notably, there are two new mouse-button operations: "Teleport pieces to or from a holder" (default Shift Left-Click) and "Switch to close-up or distant view" (default Middle-Click). The first works by selecting a holder (click on it, if it does not already have a blue frame), then Shift Left-Click on pieces to teleport them from the puzzle table to the holder. You can also select multiple pieces (e.g. edges) and transfer them all together. To teleport pieces back from a holder, select them inside the holder, then Shift Left-Click an empty spot on the puzzle table. You can also teleport pieces from one holder to another (select in the source, Shift Left-Click in the destination). Teleported pieces are still selected when they arrive, so it is easy to reverse the operation (e.g. if you pick the wrong holder).
The close-up/distant zoom operation is now a mouse button (not a keystroke), so that you can point to the exact spot in which you are interested. To search the puzzle-table systematically for pieces to sort into holders, I recommend zooming to close-up on a corner of the table, then clicking on the empty spaces in the scroll bars to step through the puzzle table a "page" at a time.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Lots of testing, with puzzles ranging from 8 to 10,000 pieces, but mainly with the same picture at 24 and 510 pieces.
There is still some tuning and fixing to be done. Mainly sizing, positioning and scaling piece holders nicely when they are created and used; also enabling/disabling of actions as you switch between the collection and puzzle views.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115946/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>