<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/114840/">https://git.reviewboard.kde.org/r/114840/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 3rd, 2014, 9:02 p.m. UTC, <b>Jaime Torres Amate</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/114840/diff/1/?file=229766#file229766line223" style="color: black; font-weight: bold; text-decoration: underline;">src/controller.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void Controller::ready(int player)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">223</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">emit</span> <span class="n">gameOver</span><span class="p">(</span><span class="n">winner</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I did not miss that one. (the other one, yes, I missed it somehow).
I changed it to emit the gameOver to show the ships just after the game is over, not just after you press the messagebox saying "have better luck next time". But this is just a matter of taste. (Es cuestión de gustos)</pre>
</blockquote>
<p>On January 3rd, 2014, 10:04 p.m. UTC, <b>Roney Gomes</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes, it's certainly about taste.
In this case I'll keep this request open until someone else give us a third opinion.</pre>
</blockquote>
<p>On January 4th, 2014, 6:54 p.m. UTC, <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">So what's the decision?
Show enemy's ships before showing the "You lost" messagebox or after pressing "ok" in the "You lost" messagebox?
If so, my vote goes for 'before showing the "You lost" messagebox'</pre>
</blockquote>
<p>On January 5th, 2014, 12:48 a.m. UTC, <b>Roney Gomes</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Alright then.
I'll update master in the next ours (not on my linux box right now) with the ships appearing before the message box, as you preferred.</pre>
</blockquote>
<p>On January 5th, 2014, 2:48 a.m. UTC, <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Note that since i'm not a super kbatlleship player my opinion should not be the one that decides, you guys should decide by yourselves, I was only giving my 0.02 worth opinion.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yeah, but in this case it's not something extremely tied to knavalbattle. It's a user interface debate, something inherently subjective.
I prefer the ships appearing after I press the button because, in my personal experience, I feel like the game is reacting to my input and thus I am sure the ships will only appear when I want them to appear.
This is good because, usually, my eyes are focused on the text message which makes me almost never see the ships appearing. And I like to seem them emerging from the sea since the fade-in animation is something I actually find pleasant to see.
But, once again, it's my personal experience which may diverge from the general one. That's why every opinion counts.</pre>
<br />
<p>- Roney</p>
<br />
<p>On January 3rd, 2014, 8:30 p.m. UTC, Roney Gomes wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Games and Jaime Torres Amate.</div>
<div>By Roney Gomes.</div>
<p style="color: grey;"><i>Updated Jan. 3, 2014, 8:30 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
knavalbattle
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Enemy ships now appear in both single player and network mode, that's cool. However, when I first started to work on this feature the ships appeared smoothly on the table after the player pressed the "OK" button of the ending KMessageBox.
As Jaime didn't work directly on the branch I set up he may have missed these two lines of code.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I've lost the game a few times in order to see the enemy ships appearing.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/battlefieldview.cpp <span style="color: grey">(b682757)</span></li>
<li>src/controller.cpp <span style="color: grey">(df44ff4)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/114840/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>