<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/113899/">https://git.reviewboard.kde.org/r/113899/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 3rd, 2014, 8:19 p.m. UTC, <b>Roney Gomes</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Are you still working on this?</pre>
</blockquote>
<p>On January 3rd, 2014, 8:51 p.m. UTC, <b>Jaime Torres Amate</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes, I was blocked on how to enable a way to restart placing ships in case of a blocked board. I have something working for local games and I'm working on the remote games now, and then remove all the debugging code and publish. </pre>
</blockquote>
<p>On January 3rd, 2014, 10 p.m. UTC, <b>Roney Gomes</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Good.
>From the player perspective, how this new feature is going to work? Is it just a predefined set of ships or the player can decide how much of each ship can be placed?
In the case of the first affirmation being true, can we predefine other sets as well? e.g.: zero of one, two of four etc.</pre>
</blockquote>
<p>On January 3rd, 2014, 10:19 p.m. UTC, <b>Jaime Torres Amate</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">At this moment, it is just a predefined set of ships (4 of size 1, 3 of size 2, 2 of size 3 and 1 of size 4), like I played in paper.
The game is ready to work with any configuration of ships in local games, because the set of ships is created when they are placed (in the AI) or to be placed (for the user).
For the network game, it will need a new message to specify the ships set if you want different ships set. Do you think this new message should be part of this patch?
Right now, for me, the hardest part has been (and continue to be) to make the two phase start (placing ships with several possible restarts and then start shooting) work for the local games and the network games.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Great.
If the game is ready to work with any set of ships than we can provide the player the chance he needs to play with the configuration he finds the best. We should only care about the space available in the grid (don't know how complex that would be).
Regarding the message stuff, I think you should implement whatever you need to make this work. Review Board may not be the best place to work when the changes are a little big, so I think you should set up a branch for this and commit your changes as you progress.</pre>
<br />
<p>- Roney</p>
<br />
<p>On November 16th, 2013, 12:50 p.m. UTC, Jaime Torres Amate wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Games and Roney Gomes.</div>
<div>By Jaime Torres Amate.</div>
<p style="color: grey;"><i>Updated Nov. 16, 2013, 12:50 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=181114">181114</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=308214">308214</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
knavalbattle
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The biggest change is the ship insertion order for the human players. It starts now by the biggest ship. This way it is impossible to reach a board where is not possible to place the remaining ships (it is possible starting with the smallest ones if there must be an space between them).
If this change is too big, then I'll try to find a solution to detect the "impossible to place more ships" situation and enable a fresh placing restart.
A kWarning() and a TODO in spanish are now gone.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">A lot of games with and without several ships, in local against the AI or in remote against myself.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/ai/ai.h <span style="color: grey">(738c465)</span></li>
<li>src/ai/dummyai.cpp <span style="color: grey">(15544e2)</span></li>
<li>src/ai/smartai.h <span style="color: grey">(fcf7dba)</span></li>
<li>src/ai/smartai.cpp <span style="color: grey">(261cf01)</span></li>
<li>src/controller.h <span style="color: grey">(e87ba48)</span></li>
<li>src/controller.cpp <span style="color: grey">(23b8153)</span></li>
<li>src/knavalbattle.kcfg <span style="color: grey">(4d78556)</span></li>
<li>src/knavalbattleui.rc <span style="color: grey">(bd38ad8)</span></li>
<li>src/mainwindow.cpp <span style="color: grey">(e3f2a35)</span></li>
<li>src/networkentity.cpp <span style="color: grey">(9f252ca)</span></li>
<li>src/playerentity.h <span style="color: grey">(aae134e)</span></li>
<li>src/playerentity.cpp <span style="color: grey">(9c32b25)</span></li>
<li>src/playfield.h <span style="color: grey">(6a24657)</span></li>
<li>src/playfield.cpp <span style="color: grey">(f1d774b)</span></li>
<li>src/sea.h <span style="color: grey">(e9e7333)</span></li>
<li>src/sea.cpp <span style="color: grey">(51f4f0c)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/113899/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>