<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/113899/">https://git.reviewboard.kde.org/r/113899/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Are you still working on this?</pre>
<br />
<p>- Roney Gomes</p>
<br />
<p>On November 16th, 2013, 12:50 p.m. UTC, Jaime Torres Amate wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Games and Roney Gomes.</div>
<div>By Jaime Torres Amate.</div>
<p style="color: grey;"><i>Updated Nov. 16, 2013, 12:50 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=181114">181114</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=308214">308214</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
knavalbattle
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The biggest change is the ship insertion order for the human players. It starts now by the biggest ship. This way it is impossible to reach a board where is not possible to place the remaining ships (it is possible starting with the smallest ones if there must be an space between them).
If this change is too big, then I'll try to find a solution to detect the "impossible to place more ships" situation and enable a fresh placing restart.
A kWarning() and a TODO in spanish are now gone.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">A lot of games with and without several ships, in local against the AI or in remote against myself.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/ai/ai.h <span style="color: grey">(738c465)</span></li>
<li>src/ai/dummyai.cpp <span style="color: grey">(15544e2)</span></li>
<li>src/ai/smartai.h <span style="color: grey">(fcf7dba)</span></li>
<li>src/ai/smartai.cpp <span style="color: grey">(261cf01)</span></li>
<li>src/controller.h <span style="color: grey">(e87ba48)</span></li>
<li>src/controller.cpp <span style="color: grey">(23b8153)</span></li>
<li>src/knavalbattle.kcfg <span style="color: grey">(4d78556)</span></li>
<li>src/knavalbattleui.rc <span style="color: grey">(bd38ad8)</span></li>
<li>src/mainwindow.cpp <span style="color: grey">(e3f2a35)</span></li>
<li>src/networkentity.cpp <span style="color: grey">(9f252ca)</span></li>
<li>src/playerentity.h <span style="color: grey">(aae134e)</span></li>
<li>src/playerentity.cpp <span style="color: grey">(9c32b25)</span></li>
<li>src/playfield.h <span style="color: grey">(6a24657)</span></li>
<li>src/playfield.cpp <span style="color: grey">(f1d774b)</span></li>
<li>src/sea.h <span style="color: grey">(e9e7333)</span></li>
<li>src/sea.cpp <span style="color: grey">(51f4f0c)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/113899/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>