<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/114513/">https://git.reviewboard.kde.org/r/114513/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/114513/diff/1/?file=225781#file225781line75" style="color: black; font-weight: bold; text-decoration: underline;">src/engine/puzzlepreview.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">75</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span class="n">setWindowTitle</span><span class="p">(</span><span class="n">i18n</span><span class="p">(</span><span class="s">"%1 - Preview"</span><span class="p">).</span><span class="n">arg</span><span class="p">(</span><span class="n">md</span><span class="p">.</span><span class="n">name</span><span class="p">));</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is wrong, it should be
i18n("%1 - Preview", md.name)</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/114513/diff/1/?file=225784#file225784line29" style="color: black; font-weight: bold; text-decoration: underline;">src/palapeliui.rc</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">29</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span class="tb"> </span><span class="o"><</span><span class="n">Action</span> <span class="n">name</span><span class="o">=</span><span class="s">"toggle_preview"</span><span class="o">/></span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Shouldn't we add this action somewhere in the menus too? I know there's some people that hide toolbars by default so if it's not in the menus they can't enable it.</pre>
</div>
<br />
<p>- Albert Astals Cid</p>
<br />
<p>On December 16th, 2013, 9:48 p.m. UTC, Ian Wadham wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Games.</div>
<div>By Ian Wadham.</div>
<p style="color: grey;"><i>Updated Dec. 16, 2013, 9:48 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
palapeli
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Facility to preview a completed Palapeli jigsaw puzzle.
Original by Johannes Loehnert, 2010, modified by Ian Wadham to use current Palapeli interfaces.
The preview is controlled by a button in the toolbar, which is enabled when a puzzle is being solved. It appears in a floating tool-window and can be shown or hidden at will. The window can be moved, resized, maximized or closed (hidden, but not deleted). It is deleted when the user returns to the puzzle-collection view or terminates Palapeli when in solving mode. The window's title is derived from the name of the puzzle, e.g. "Citrus Fruits - Preview". Its visibility and geometry are saved in Settings between uses. If visibility is on in Settings, the puzzle preview appears immediately a puzzle is requested and can be viewed while the puzzle is loading.
When the mouse pointer is moved into the preview window, the view is automatically magnified to show an area of at least 3x3 pieces. As the pointer moves around, the view automatically scrolls, to allow the user to home in rapidly on any detail of the puzzle's image.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Developed and tested on an Apple Macbook OS X platform, using KDE from Macports.
Tested all the features described above, including title bar buttons. Also tested cases where image and Palapeli metadata are unavailable, in which case the preview contains a text message and a generic title.
On Apple, the Minimize button is disabled and has not been tested. I am not sure if it will be enabled in Linux, nor what its effect should be.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/window/mainwindow.cpp <span style="color: grey">(e3305fb)</span></li>
<li>src/window/mainwindow.h <span style="color: grey">(f94e52c)</span></li>
<li>src/palapeliui.rc <span style="color: grey">(d888c0d)</span></li>
<li>src/main.cpp <span style="color: grey">(f7fec86)</span></li>
<li>src/palapeli.kcfg <span style="color: grey">(b30d6b1)</span></li>
<li>src/engine/puzzlepreview.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/engine/puzzlepreview.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(c648c91)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/114513/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>