<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113782/">http://git.reviewboard.kde.org/r/113782/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On November 11th, 2013, 12:48 p.m. UTC, <b>Nemanja Hirsl</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">At the end of the game there is "Final standings" modal dialog which contains the same info as "Standings" dialog. Is there a way to use just one and to end game in different way? </pre>
</blockquote>
<p>On November 16th, 2013, 5:58 a.m. UTC, <b>Alexander Schuch</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I do not fully understand what you mean.
>From a code point of view, there only is one widget for the standings overview. It is used in the dock and in the dialogue.
Winning the game (or losing it) is a singular event as the actual game ceases to exist. This deserves modal information. Maybe the standings dock could be closed. But this might be confusing if just the standings dock closes but the messages dock stays open. Closing the messages dock as well might hide information the player is interested in. So in short, I do not fully understand what you mean and about what you could mean, I have no better idea right now.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It was probably because standings overview was by default on and when game ended it appeared again as modal. It looks little odd to have the same table one on top of the another showing the same data. I just wanted to ask if you have any idea how not to use it if it already present?
One way (I'm not saying it is right way) is to put focus on current standings overview if it is visible or to show it, if it is not. This raises new questions do we need modal dialog at the end and what should be there?
I'm OK with current implementation because it is behaving in the same way as it used to, the purpose of this comment is just to ask if there are other (better) ways to handle this situations. </pre>
<br />
<p>- Nemanja</p>
<br />
<p>On November 16th, 2013, 5:58 a.m. UTC, Alexander Schuch wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Games.</div>
<div>By Alexander Schuch.</div>
<p style="color: grey;"><i>Updated Nov. 16, 2013, 5:58 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
konquest
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The dialogue "current standings" is replaced by a dockable widget. This way the player is able to see the standings all the time without the need to open/close the dialogue at the beginning of each turn.
The dockable widget can also be made floating, so it can be used almost the same as the modal dialogue before.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(3b321ad)</span></li>
<li>dialogs/scoredlg.h <span style="color: grey">(bda18a5)</span></li>
<li>dialogs/scoredlg.cc <span style="color: grey">(5e66cd4)</span></li>
<li>gameview.h <span style="color: grey">(7d8700e)</span></li>
<li>gameview.cc <span style="color: grey">(f67d570)</span></li>
<li>konquestui.rc <span style="color: grey">(683cd11)</span></li>
<li>mainwin.h <span style="color: grey">(663177b)</span></li>
<li>mainwin.cc <span style="color: grey">(2b4cece)</span></li>
<li>view/standingswidget.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>view/standingswidget.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113782/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>