<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113528/">http://git.reviewboard.kde.org/r/113528/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">To be honest, now that we are frozen for release i'd prefer if you minimized the changes we do, i.e. there's lots of changes that are just cleanup/beatification of the code, that is all good, but may produce regressions and now that we are frozen for 4.12 i'd prefer if we make things that are "fix" really be the "fix" only. what's your opinion?</pre>
<br />
<p>- Albert Astals Cid</p>
<br />
<p>On November 3rd, 2013, 5:10 p.m. UTC, Alexander Schuch wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Games.</div>
<div>By Alexander Schuch.</div>
<p style="color: grey;"><i>Updated Nov. 3, 2013, 5:10 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
konquest
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The recently added KStandardGameAction::endTurn() action now has an own
default shortcut of Ctrl+E. The button is added to the toolbar by default.
Furthermore, the "end turn" button now is enabled/disabled depending on the
game state. It no longer is possible to end the turn while in the middle of
a send fleet command sequence.
Use the very same condition for enabling/disabling the custom "end turn"
button and the "end turn" action.
The custom palette for the game board now colours disabled elements darker
so that they actually look disabled.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>gameview.cc <span style="color: grey">(a01bfde)</span></li>
<li>konquestui.rc <span style="color: grey">(cd43d33)</span></li>
<li>mainwin.h <span style="color: grey">(d72fd46)</span></li>
<li>mainwin.cc <span style="color: grey">(929c61d)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113528/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>