<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113113/">http://git.reviewboard.kde.org/r/113113/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On October 22nd, 2013, 5:10 p.m. UTC, <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Nemanja, code looks good to me. If it looks good to you to, can you take care of commiting it to the master branch?</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes, the code looks good. I'll commit it to the master branch today or tomorrow (as soon as I find some time).</pre>
<br />
<p>- Nemanja</p>
<br />
<p>On October 22nd, 2013, 2:23 a.m. UTC, Alexander Schuch wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Games.</div>
<div>By Alexander Schuch.</div>
<p style="color: grey;"><i>Updated Oct. 22, 2013, 2:23 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
konquest
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">For AI development it is useful to watch the AIs play. This patch adds a new local human spectator player controller which does not have any planets and does not count as active player.
In case all selected player controllers are spectators, or only one non-spectating player controller is set, consider the match as spectator-only and reject it as there is either no winner at all, or the winner is known already (the only non-spectating player).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>players/spectatorplayer_gui.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>players/spectatorplayer.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>players/spectatorplayer_gui.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>players/spectatorplayer.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>players/player.h <span style="color: grey">(a6d91c4)</span></li>
<li>players/player.cpp <span style="color: grey">(7135127)</span></li>
<li>players/localplayer_gui.cpp <span style="color: grey">(44a04b5)</span></li>
<li>players/localplayer.h <span style="color: grey">(a12b46f)</span></li>
<li>players/localplayer.cpp <span style="color: grey">(dbb47f3)</span></li>
<li>players/computerplayer.cpp <span style="color: grey">(f4fd7a2)</span></li>
<li>gameview.cc <span style="color: grey">(ebba726)</span></li>
<li>players/computerplayer.h <span style="color: grey">(29b6b77)</span></li>
<li>CMakeLists.txt <span style="color: grey">(b67b4ba)</span></li>
<li>dialogs/newgamedlg.h <span style="color: grey">(70e8a1a)</span></li>
<li>dialogs/newgamedlg.cc <span style="color: grey">(6f376ed)</span></li>
<li>game.cpp <span style="color: grey">(5746b22)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113113/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>