<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113113/">http://git.reviewboard.kde.org/r/113113/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On October 16th, 2013, 9:23 p.m. UTC, <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">How hard would be to check on start that not all players are spectators and complain if they are all?</pre>
</blockquote>
<p>On October 18th, 2013, 11:51 p.m. UTC, <b>Nemanja Hirsl</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Newgamedialog already have some code for enabling/disabling Ok/Cancel buttons. Maybe this code should be improved and not allow game with all spectators? </pre>
</blockquote>
<p>On October 19th, 2013, 5:55 p.m. UTC, <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Makes sense to me. Alexander?</pre>
</blockquote>
<p>On October 19th, 2013, 11:32 p.m. UTC, <b>Alexander Schuch</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I implemented this check. If you know how to do it better using signals, please update. :)
During tests I noticed more problems, but I am not sure where they belong to - to the bug tracker or as @todo in the code?
For example, set the neutral player production to any high value (anything above 10) and disable cumulative production. No player will be able to conquer any planet and the game will take forever. If playing without any human player (AI match), the game will "freeze". Or play a game with zero neutral planets - same issue. Or set the starting planets of each player to "vacant".</pre>
</blockquote>
<p>On October 20th, 2013, 5:04 p.m. UTC, <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">What do you mean that the game will freeze if there's no human player? That works just fine here (in version from KDE 4.11.2)</pre>
</blockquote>
<p>On October 20th, 2013, 9:40 p.m. UTC, <b>Nemanja Hirsl</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Alexander, issues which are reproducible on 4.11 should be reported as bugs, others, if there are any, are regressions. For now, after testing and reviewing code, I believe (and hope) we didn't create any. Some of issues you mentioned I didn't succeed to reproduce (issue related to high neutral player production with disabled cumulative production) by using code from master and this patch. However, on both 4.11.2 and master there is a "freeze" - actually infinite loop in case of AI match without neutral planets. So, there are obviously some problems and it would be good if we could filter them out. If you have time, please report bugs for appropriate versions.
Just small notes for this code and current behavior:
1. Setup where one of two players is spectator is allowed and OK button can be pressed. The outcome is obvious - the winner is non-spectator.
2. If player is spectator should we allow kill percentage and production to be set up?
Everything else looks good.
</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I too believe that we did not introduce new bugs - they all seem to be present already. I will report bugs to the bug tracker at some later time then.
1. I updated the patch again to check for this condition as well.
2. All planets handled by a spectator player controller will be turned over to neutral planets as soon as the match starts. This is the only sane way to handle this within the current implementation. So if you adjust the parameters of those planets, they will be used for the turned over neutral planet then.</pre>
<br />
<p>- Alexander</p>
<br />
<p>On October 19th, 2013, 11:33 p.m. UTC, Alexander Schuch wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Games.</div>
<div>By Alexander Schuch.</div>
<p style="color: grey;"><i>Updated Oct. 19, 2013, 11:33 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
konquest
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">For AI development it is useful to watch the AIs play. This patch adds a new local human spectator player which does not have any planets and does not count as active player. The game is not allowed to start when all player controllers are spectators.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(b67b4ba)</span></li>
<li>dialogs/newgamedlg.h <span style="color: grey">(70e8a1a)</span></li>
<li>dialogs/newgamedlg.cc <span style="color: grey">(6f376ed)</span></li>
<li>game.cpp <span style="color: grey">(5746b22)</span></li>
<li>gameview.cc <span style="color: grey">(ebba726)</span></li>
<li>players/computerplayer.h <span style="color: grey">(29b6b77)</span></li>
<li>players/computerplayer.cpp <span style="color: grey">(f4fd7a2)</span></li>
<li>players/localplayer.h <span style="color: grey">(a12b46f)</span></li>
<li>players/localplayer.cpp <span style="color: grey">(dbb47f3)</span></li>
<li>players/localplayer_gui.cpp <span style="color: grey">(44a04b5)</span></li>
<li>players/player.h <span style="color: grey">(a6d91c4)</span></li>
<li>players/player.cpp <span style="color: grey">(7135127)</span></li>
<li>players/spectatorplayer.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>players/spectatorplayer.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>players/spectatorplayer_gui.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>players/spectatorplayer_gui.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113113/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>