<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112676/">http://git.reviewboard.kde.org/r/112676/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On October 7th, 2013, 10:02 p.m. UTC, <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/112676/diff/2/?file=193309#file193309line479" style="color: black; font-weight: bold; text-decoration: underline;">dialogs/newgamedlg.cc</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">NewGameDlg::slotRemovePlayer()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">443</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cm"> * @todo This method is not used!</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Just kill it if not used?</pre>
</blockquote>
<p>On October 8th, 2013, 1:03 a.m. UTC, <b>Alexander Schuch</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I like to keep it in order to add sanity checks. A game of all spectators (other patch) should not be allowed, a game full of AI should (one round tournament mode). Right now I am just not yet into this signal/slot thing to be able to revive this. Maybe you can help?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The other possibility I see is that we use code like NewGameDlg::slotRemovePlayer() or NewGameDlg::slotAddPlayer() to enable/disable the "Ok" button depending on the configuration. If the configuration is sane, enable the button so that the game can be started, if it is not sane, disable it. But this needs adding more signals to change events of the player controller drop down selection for example.
What do you think?</pre>
<br />
<p>- Alexander</p>
<br />
<p>On October 8th, 2013, 1:03 a.m. UTC, Alexander Schuch wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Games.</div>
<div>By Alexander Schuch.</div>
<p style="color: grey;"><i>Updated Oct. 8, 2013, 1:03 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
konquest
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The default AI is handled by players/ai/default/default.cpp. The difficulty is wrapped in own classes so that the external interface is the same for all players (AI and human).
Adding new AI players is as easy as to implement the code in an own class, add a GUI wrapper (see ai/example) and add the GUI wrapper to m_selectablePlayer in NewGameDlg constructor.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(0e8a354)</span></li>
<li>dialogs/newgamedlg.h <span style="color: grey">(10ce4ee)</span></li>
<li>dialogs/newgamedlg.cc <span style="color: grey">(be764f1)</span></li>
<li>players/ai/default/default.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>players/ai/default/default.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>players/ai/default/hard.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>players/ai/default/hard.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>players/ai/default/hard_gui.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>players/ai/default/hard_gui.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>players/ai/default/normal.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>players/ai/default/normal.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>players/ai/default/normal_gui.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>players/ai/default/normal_gui.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>players/ai/default/weak.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>players/ai/default/weak.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>players/ai/default/weak_gui.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>players/ai/default/weak_gui.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>players/ai/example/example.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>players/ai/example/example.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>players/ai/example/example_gui.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>players/ai/example/example_gui.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>players/computerplayer.h <span style="color: grey">(ec25217)</span></li>
<li>players/computerplayer.cpp <span style="color: grey">(2df7dd8)</span></li>
<li>players/localplayer_gui.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>players/localplayer_gui.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>players/player.h <span style="color: grey">(be0133a)</span></li>
<li>players/player_gui.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>players/player_gui.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112676/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>