<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112676/">http://git.reviewboard.kde.org/r/112676/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 22nd, 2013, 3:11 p.m. UTC, <b>Nemanja Hirsl</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/112676/diff/1/?file=189007#file189007line24" style="color: black; font-weight: bold; text-decoration: underline;">players/ai/default/normal_gui.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">24</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">PlayerGui</span><span class="p">(</span><span class="n">i18n</span><span class="p">(</span><span class="s">"Default Normal/Offensive"</span><span class="p">))</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">These strings are too long for type of player in the dialog. One can't see what it is unless the dialog is expanded. Maybe a tooltip could help in combination with shorter name?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Or maybe change the dialog code so that it fits?</pre>
<br />
<p>- Albert</p>
<br />
<p>On September 15th, 2013, 3:36 p.m. UTC, Alexander Schuch wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Games.</div>
<div>By Alexander Schuch.</div>
<p style="color: grey;"><i>Updated Sept. 15, 2013, 3:36 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The default AI is handled by players/ai/default/default.cpp. The difficulty is wrapped in own classes so that the external interface is the same for all players (AI and human).
Adding new AI players is as easy as to implement the code in an own class, add a GUI wrapper (see ai/example) and add the GUI wrapper to m_selectablePlayer in NewGameDlg constructor.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(0e8a354)</span></li>
<li>dialogs/newgamedlg.h <span style="color: grey">(10ce4ee)</span></li>
<li>dialogs/newgamedlg.cc <span style="color: grey">(be764f1)</span></li>
<li>players/ai/default/default.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>players/ai/default/default.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>players/ai/default/hard.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>players/ai/default/hard.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>players/ai/default/hard_gui.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>players/ai/default/hard_gui.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>players/ai/default/normal.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>players/ai/default/normal.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>players/ai/default/normal_gui.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>players/ai/default/normal_gui.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>players/ai/default/weak.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>players/ai/default/weak.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>players/ai/default/weak_gui.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>players/ai/default/weak_gui.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>players/ai/example/example.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>players/ai/example/example.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>players/ai/example/example_gui.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>players/ai/example/example_gui.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>players/computerplayer.h <span style="color: grey">(ec25217)</span></li>
<li>players/computerplayer.cpp <span style="color: grey">(2df7dd8)</span></li>
<li>players/localplayer_gui.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>players/localplayer_gui.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>players/player.h <span style="color: grey">(be0133a)</span></li>
<li>players/player_gui.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>players/player_gui.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112676/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/09/15/0004-Show-player-controller-name-when-adding-a-new-player.patch">show player controller name when adding a new player</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>