<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/112676/">http://git.reviewboard.kde.org/r/112676/</a>
     </td>
    </tr>
   </table>
   <br />




<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for KDE Games.</div>
<div>By Alexander Schuch.</div>


<p style="color: grey;"><i>Updated Sept. 15, 2013, 3:36 p.m.</i></p>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Adding a new player previously always added the local player but no "type" was shown. Now the first available player controller (human or AI) will be added along with its name. This issue has been introduced by the previous patch.</pre>
  </td>
 </tr>
</table>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The default AI is handled by players/ai/default/default.cpp. The difficulty is wrapped in own classes so that the external interface is the same for all players (AI and human).

Adding new AI players is as easy as to implement the code in an own class, add a GUI wrapper (see ai/example) and add the GUI wrapper to m_selectablePlayer in NewGameDlg constructor.</pre>
  </td>
 </tr>
</table>





<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>CMakeLists.txt <span style="color: grey">(0e8a354)</span></li>

 <li>dialogs/newgamedlg.h <span style="color: grey">(10ce4ee)</span></li>

 <li>dialogs/newgamedlg.cc <span style="color: grey">(be764f1)</span></li>

 <li>players/ai/default/default.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>players/ai/default/default.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>players/ai/default/hard.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>players/ai/default/hard.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>players/ai/default/hard_gui.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>players/ai/default/hard_gui.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>players/ai/default/normal.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>players/ai/default/normal.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>players/ai/default/normal_gui.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>players/ai/default/normal_gui.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>players/ai/default/weak.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>players/ai/default/weak.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>players/ai/default/weak_gui.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>players/ai/default/weak_gui.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>players/ai/example/example.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>players/ai/example/example.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>players/ai/example/example_gui.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>players/ai/example/example_gui.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>players/computerplayer.h <span style="color: grey">(ec25217)</span></li>

 <li>players/computerplayer.cpp <span style="color: grey">(2df7dd8)</span></li>

 <li>players/localplayer_gui.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>players/localplayer_gui.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>players/player.h <span style="color: grey">(be0133a)</span></li>

 <li>players/player_gui.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>players/player_gui.cpp <span style="color: grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/112676/diff/" style="margin-left: 3em;">View Diff</a></p>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments (updated)</h1>

<ul>

 <li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/09/15/0004-Show-player-controller-name-when-adding-a-new-player.patch">show player controller name when adding a new player</a></li>

</ul>





  </td>
 </tr>
</table>




  </div>
 </body>
</html>