<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110788/">http://git.reviewboard.kde.org/r/110788/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On June 10th, 2013, 11:07 p.m. UTC, <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/110788/diff/5/?file=149516#file149516line238" style="color: black; font-weight: bold; text-decoration: underline;">grafix/default.rc</a>
<span style="font-weight: normal;">
(Diff revision 5)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">238</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="n">fontColorActive</span><span class="o">=</span><span class="m">255</span><span class="p">,</span><span class="m">255</span><span class="p">,</span><span class="m"><span class="hl">0</span></span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">238</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="n">fontColorActive</span><span class="o">=</span><span class="m">255</span><span class="p">,</span><span class="m">255</span><span class="p">,</span><span class="m"><span class="hl">255</span></span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Why all these changes in fontColorActive & friends?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Player colors in score board was a mess:
BEFORE
Black and red theme: red for black player, black for red player, yellow for active player.
Yellow and red theme: white for yellow player, red for red player, yellow for active player.
NOW
Black and red theme: black for black player, red for red player, white for active player.
Yellow and red theme: yellow for yellow player, red for red player, white for active player.</pre>
<br />
<p>- Eneko</p>
<br />
<p>On June 10th, 2013, 10:55 p.m. UTC, Eneko Nieto wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Games.</div>
<div>By Eneko Nieto.</div>
<p style="color: grey;"><i>Updated June 10, 2013, 10:55 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Added player color names to theme files. This helps fixing inconsistencies in naming player colors because different themes uses different colors.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested all themes. Only color names in status bar have been fixed.
Color names in settings dialog have not been fixed because settings dialog remove in near future.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=154687">154687</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>grafix/default.desktop <span style="color: grey">(7a78ad9)</span></li>
<li>grafix/default.rc <span style="color: grey">(006f510)</span></li>
<li>grafix/gray_reflection.desktop <span style="color: grey">(60be4aa)</span></li>
<li>grafix/gray_reflection.rc <span style="color: grey">(174a025)</span></li>
<li>grafix/yellow.desktop <span style="color: grey">(582c3e1)</span></li>
<li>grafix/yellow.rc <span style="color: grey">(45787cc)</span></li>
<li>grafix/yellow_reflection.desktop <span style="color: grey">(17d8fe2)</span></li>
<li>grafix/yellow_reflection.rc <span style="color: grey">(3ef8d76)</span></li>
<li>src/kwin4.h <span style="color: grey">(af0a2e5)</span></li>
<li>src/kwin4.cpp <span style="color: grey">(03be331)</span></li>
<li>src/thememanager.cpp <span style="color: grey">(7683bf2)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110788/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>