<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110788/">http://git.reviewboard.kde.org/r/110788/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On June 9th, 2013, 11:15 a.m. UTC, <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Do you think you can fix the "Black Plays With"/"Red Plays With" using this new thing? Or you prefer we commit this first and fix that later?</pre>
</blockquote>
<p>On June 9th, 2013, 8:09 p.m. UTC, <b>Eneko Nieto</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I was not fixing the settings dialog because it will be removed with the planned changes. I am working in them right now, but advancing slow, still too much qt to learn.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thing is, your new dialog can't go into 4.11 (which will be released soon) because it's a new feature, but this and the change to make "Black Plays With"/"Red Plays With" use your new colors could, since they fix bugs. So hence my question, do you want me to commit this first and then you work on fixing the other bug for 4.11 or you prefer to wait for the new feature for 4.12 or?
Do not hesitate to tell me if i'm not explaining myself correctly enough</pre>
<br />
<p>- Albert</p>
<br />
<p>On June 3rd, 2013, 11:36 p.m. UTC, Eneko Nieto wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Games.</div>
<div>By Eneko Nieto.</div>
<p style="color: grey;"><i>Updated June 3, 2013, 11:36 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Added player color names to theme files. This helps fixing inconsistencies in naming player colors because different themes uses different colors.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested all themes. Only color names in status bar have been fixed.
Color names in settings dialog have not been fixed because settings dialog remove in near future.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=154687">154687</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>grafix/default.desktop <span style="color: grey">(7a78ad9)</span></li>
<li>grafix/gray_reflection.desktop <span style="color: grey">(60be4aa)</span></li>
<li>grafix/yellow.desktop <span style="color: grey">(582c3e1)</span></li>
<li>grafix/yellow_reflection.desktop <span style="color: grey">(17d8fe2)</span></li>
<li>src/kwin4.h <span style="color: grey">(af0a2e5)</span></li>
<li>src/kwin4.cpp <span style="color: grey">(03be331)</span></li>
<li>src/thememanager.cpp <span style="color: grey">(7683bf2)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110788/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>