<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110650/">http://git.reviewboard.kde.org/r/110650/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On May 26th, 2013, 9:50 p.m. UTC, <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm confused, what does have hiding the toolbar have to do with hiding the menubar?</pre>
</blockquote>
<p>On May 27th, 2013, 12:20 a.m. UTC, <b>Matthew Scheirer</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">There are 3 ways to toggle the toolbar - settings in the menu, right click on the menu (where the context menu only has the hide main toolbar option) or by unlocking the toolbar by its context menu and going back in and hiding it.
The other option was to make it a setting to make the main toolbar unremovable, at least for me. I just wanted a way to keep him from accidently right clicking, holding it, and hitting the main toolbar toggle, and not knowing what to do.
But this is just adding the generic KStandardAction keybind to toggle the menubar, I just did it so I can avoid having the toolbar removed from settings or the menubar context menu.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I am still not getting it. This adds a menu entry and a shortcut to toggle the menubar, how does this make it so that he can't hide the toolbar?</pre>
<br />
<p>- Albert</p>
<br />
<p>On May 26th, 2013, 3:24 p.m. UTC, Matthew Scheirer wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Games.</div>
<div>By Matthew Scheirer.</div>
<p style="color: grey;"><i>Updated May 26, 2013, 3:24 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Adds the ctrl-m standard keyboard shortcut to hide the menubar, with a warning prompt. Mainly for my grandfather who would right click the menubar and diable the main toolbar and not know what to do.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Shortcut works, settings preserved across multiple sessions.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=320269">320269</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>mainwindow.h <span style="color: grey">(c9cbeae)</span></li>
<li>mainwindow.cpp <span style="color: grey">(a42f8ef)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110650/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>