<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110132/">http://git.reviewboard.kde.org/r/110132/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 22nd, 2013, 9:36 p.m. UTC, <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">What's the problem with the existing one provided by kdeclarative?</pre>
</blockquote>
<p>On April 23rd, 2013, 8:51 a.m. UTC, <b>Viranch Mehta</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">its part of plasma components and using it would add a dependency to kde-runtime.</pre>
</blockquote>
<p>On April 23rd, 2013, 9:08 a.m. UTC, <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">kde-runtime is a dependency of all the kde apps.
Besides it's not in kde-runtime is in kdelibs and we are already using the kdeclarative library ;-)</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">oh right, I was thinking about the PlasmaCore.IconItem component. we already have the image provider in kdeclarative. don't need this.</pre>
<br />
<p>- Viranch</p>
<br />
<p>On April 22nd, 2013, 9:11 p.m. UTC, Viranch Mehta wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Games.</div>
<div>By Viranch Mehta.</div>
<p style="color: grey;"><i>Updated April 22, 2013, 9:11 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch introduces a new image provider for libkdegames that enables showing KIcon's inside QML. Additionally, ships a KIcon QML component as a wrapper component that takes in the KIcon's name and uses the image provider to show the pixmap.
The purpose of the image provider is for the QML component that I'm working on for KGamePopupItem. Many games use this and should be a readily available component. This component shows a KIcon as its icon alongside the text, hence the patch and the new image provider.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested with a simple QML file: http://sprunge.us/Ggje and "qmlviewer -I $KDEDIR/lib/kde4/imports test.qml". shows the correct icon image.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>declarativeimports/CMakeLists.txt <span style="color: grey">(c5b88d9)</span></li>
<li>declarativeimports/corebindingsplugin.h <span style="color: grey">(bc3fa32)</span></li>
<li>declarativeimports/corebindingsplugin.cpp <span style="color: grey">(3fef508)</span></li>
<li>declarativeimports/kiconprovider.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>declarativeimports/kiconprovider_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>declarativeimports/qml/KIcon.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>declarativeimports/qml/qmldir <span style="color: grey">(79aae32)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110132/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>