<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109880/">http://git.reviewboard.kde.org/r/109880/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 10th, 2013, 8:42 p.m. UTC, <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The code's much easier to understand now. Thanks a lot :-)
So now that we can understand the code, can you explain what's the improvement this provides over the current code?</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">In previous case everything was left to random, so the minimum moves to win is unpredictable. In easy level i once won with 11 moves that means in that board more than 14 cells remained unmoved. I also got 34 moves in easy level. This make getting highscore on the basis of luck. Since there is custom level with 9 cells leaving everything on random is not a good idea.</pre>
<br />
<p>- Ashwin</p>
<br />
<p>On April 10th, 2013, 4:08 p.m. UTC, Ashwin Rajeev wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Games, Albert Astals Cid and Parker Coates.</div>
<div>By Ashwin Rajeev.</div>
<p style="color: grey;"><i>Updated April 10, 2013, 4:08 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Instead of randomly rotating every cell, rotate random cells such that initial and final state are not same and minimum moves to win is equal to shuffle limit.
This will also make sure the highscore is impartial on every game.
I am also thinking of committing new highscore method since this patch will make getting highscore impossible for some cases.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=160470">160470</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/abstractgrid.cpp <span style="color: grey">(63ed8b8)</span></li>
<li>src/globals.h <span style="color: grey">(6df25a0)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109880/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>