<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109880/">http://git.reviewboard.kde.org/r/109880/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 6th, 2013, 10:11 p.m. UTC, <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Can you please explain (as comment in the code) what the new algorithm does? The old one was pretty simple, go thorugh all the cells and rotate them. But i tried understanding the new one you made and it's not that easy, so a comment would certainly help whoever comes in 2 years and tries to see what it is doing</pre>
</blockquote>
<p>On April 7th, 2013, 8:01 a.m. UTC, <b>Ashwin Rajeev</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">To reduce the complexity i am thinking of dropping this case "if (m_minimumMoves == shufflelimit - 1)" . What is your opinion ?
Then for each level minimumMoves to win will be shufflelimit or shufflelimit + 1 instead of just shufflelimit.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Don't know, as said i tried to understand what you're trying to do and failed. Specially shuffledCells and the rand() moduled over the decrementing i makes my brain get lost :D That's why i asked you to do a full comment of what the algorithm does.</pre>
<br />
<p>- Albert</p>
<br />
<p>On April 6th, 2013, 3:27 p.m. UTC, Ashwin Rajeev wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Games, Albert Astals Cid and Parker Coates.</div>
<div>By Ashwin Rajeev.</div>
<p style="color: grey;"><i>Updated April 6, 2013, 3:27 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">While minimum moves to win is less than or equal to minimum number of cells in that particular difficulty level shuffle a random cell that is not yet shuffled.
This will also make sure the highscore is impartial on every game.
I am also thinking of committing new highscore method since this patch will make getting highscore impossible for some cases.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=160470">160470</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/abstractgrid.cpp <span style="color: grey">(63ed8b8)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109880/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>