<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109885/">http://git.reviewboard.kde.org/r/109885/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/109885/diff/1/?file=131657#file131657line66" style="color: black; font-weight: bold; text-decoration: underline;">src/board.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">BomberBoard::BomberBoard(KGameRenderer *renderer, QGraphicsView* view, QObject *parent) :</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">65</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span class="n">clear</span><span class="p">();</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">66</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">clear</span><span class="p">();</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">spacing</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/109885/diff/1/?file=131657#file131657line234" style="color: black; font-weight: bold; text-decoration: underline;">src/board.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void BomberBoard::tick()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">229</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span class="tb"> </span><span class="n">m_bomb</span> <span class="o">=</span> <span class="k">new</span> <span class="n">Bomb</span><span class="p">(</span><span class="n">m_renderer</span><span class="p">,</span> <span class="k">this</span><span class="p">,</span> <span class="n">planePos</span><span class="p">.</span><span class="n">x</span><span class="p">(),</span> <span class="n">planePos</span><span class="p">.</span><span class="n">y</span><span class="p">()</span> <span class="o">+</span> <span class="mi">1</span><span class="p">,</span> <span class="n">m_tileSize</span><span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">234</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">m_bomb</span> <span class="o">=</span> <span class="k">new</span> <span class="n">Bomb</span><span class="p">(</span><span class="n">m_renderer</span><span class="p">,</span> <span class="k">this</span><span class="p">,</span> <span class="n">planePos</span><span class="p">.</span><span class="n">x</span><span class="p">(),</span> <span class="n">planePos</span><span class="p">.</span><span class="n">y</span><span class="p">()</span> <span class="o">+</span> <span class="mi">1</span><span class="p">,</span> <span class="n">m_tileSize</span><span class="hl"> </span><span class="p"><span class="hl">,</span></span><span class="hl"> </span><span class="n"><span class="hl">m_plane</span></span><span class="o"><span class="hl">-></span></span><span class="n"><span class="hl">xVelocity</span></span><span class="p"><span class="hl">()</span>);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You have broken spacing in many places.</pre>
</div>
<br />
<p>- Ashwin</p>
<br />
<p>On April 6th, 2013, 3:06 p.m. UTC, Anant Pushkar wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Games.</div>
<div>By Anant Pushkar.</div>
<p style="color: grey;"><i>Updated April 6, 2013, 3:06 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The bombs earlier used to fall in straight line vertically. In this patch, I have made the path of the bomb a projectile just like in real life to make it look realistic. A side effect of this is that hitting the buildings in the beginning would be a little difficult. To tackle this, the average height of the first two buildings have been reduced.
Also, in cases when the plane crashes and not many blocks are still left, taking an aim from a larger height becomes difficult. Due to this the player has to wait till the plane itself comes down to a desired height. So, I have added a function that allows the player to lower the altitude of the plane by pressing the down button. I have a number of other features in mind that can be implemented as well. I will be soon submitting them.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I would also like to add that I have tested the changes exhaustively and have found it to work well and improve the user experience.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/board.h <span style="color: grey">(3816b95)</span></li>
<li>src/board.cpp <span style="color: grey">(1dd99a3)</span></li>
<li>src/bomb.h <span style="color: grey">(adf8541)</span></li>
<li>src/bomb.cpp <span style="color: grey">(7d361f5)</span></li>
<li>src/bomber.cpp <span style="color: grey">(4cd276f)</span></li>
<li>src/bomberwidget.h <span style="color: grey">(d807294)</span></li>
<li>src/bomberwidget.cpp <span style="color: grey">(497d8e1)</span></li>
<li>src/explodable.h <span style="color: grey">(aca7735)</span></li>
<li>src/explodable.cpp <span style="color: grey">(773f55f)</span></li>
<li>src/main.cpp <span style="color: grey">(05f4686)</span></li>
<li>src/plane.h <span style="color: grey">(acc8c8b)</span></li>
<li>src/plane.cpp <span style="color: grey">(a805415)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109885/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>