<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109687/">http://git.reviewboard.kde.org/r/109687/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/109687/diff/1/?file=121273#file121273line68" style="color: black; font-weight: bold; text-decoration: underline;">src/networkdialog.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">NetworkDialog::NetworkDialog(bool client, QWidget* parent, const KUrl* url)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">68</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">DNSSD</span><span class="o">::</span><span class="n">ServiceBrowser</span><span class="o">*</span> <span class="n">browser</span><span class="o">=</span><span class="k">new</span> <span class="n">DNSSD</span><span class="o">::</span><span class="n">ServiceBrowser</span><span class="p">(</span><span class="s">"_kbattle<span class="hl">ship</span>._tcp"</span><span class="p">,</span> <span class="nb">true</span><span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">68</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">DNSSD</span><span class="o">::</span><span class="n">ServiceBrowser</span><span class="o">*</span> <span class="n">browser</span><span class="o">=</span><span class="k">new</span> <span class="n">DNSSD</span><span class="o">::</span><span class="n">ServiceBrowser</span><span class="p">(</span><span class="s">"_k<span class="hl">naval</span>battle._tcp"</span><span class="p">,</span> <span class="nb">true</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Not sure this is a good idea, we loose the ability to play with other kbattleship players via dnssd for no "real reason"</pre>
</div>
<br />
<p>- Albert</p>
<br />
<p>On March 24th, 2013, 2:54 p.m. UTC, Roney Gomes wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Games.</div>
<div>By Roney Gomes.</div>
<p style="color: grey;"><i>Updated March 24, 2013, 2:54 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">During KNavalbattle's port to QGraphicsView I was informed that it was previously called KBattleship and that this name couldn't be used anymore due copyright issues. Even so, the final compiled binary as well as the application's folder, its image and configuration files are still named making references to "kbattleship".
Thus, as I don't like to build a project called KNavalbattle and then have to call the "kbattleship" binary, I replaced all references to "kbattleship" in the building files.
A few files will appear as deleted but they were actually renamed to satisfy the new project's name. They'll appear as newly included files in the commit.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">A clean build and a lookup in the program's installation directory in order to check whether it all has been organized the way I intended.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(9a4e3f8)</span></li>
<li>data/pictures/CMakeLists.txt <span style="color: grey">(32c7fb3)</span></li>
<li>data/pictures/hi128-app-kbattleship.png <span style="color: grey">(e54f635)</span></li>
<li>data/pictures/hi16-app-kbattleship.png <span style="color: grey">(befa7c8)</span></li>
<li>data/pictures/hi22-app-kbattleship.png <span style="color: grey">(f0302bd)</span></li>
<li>data/pictures/hi32-app-kbattleship.png <span style="color: grey">(7a8e63d)</span></li>
<li>data/pictures/hi48-app-kbattleship.png <span style="color: grey">(9d3fd17)</span></li>
<li>data/pictures/hi64-app-kbattleship.png <span style="color: grey">(69cf15f)</span></li>
<li>data/sounds/CMakeLists.txt <span style="color: grey">(7833b8e)</span></li>
<li>doc/CMakeLists.txt <span style="color: grey">(4e314e5)</span></li>
<li>doc/index.docbook <span style="color: grey">(7bc34ec)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(224e890)</span></li>
<li>src/Messages.sh <span style="color: grey">(1f3f6ff)</span></li>
<li>src/kbattleship.desktop <span style="color: grey">(1bcedd9)</span></li>
<li>src/kbattleship.kcfg <span style="color: grey">(bc6212b)</span></li>
<li>src/kbattleship.protocol <span style="color: grey">(7efd32e)</span></li>
<li>src/kbattleshipui.rc <span style="color: grey">(5f4f951)</span></li>
<li>src/main.cpp <span style="color: grey">(1f8c219)</span></li>
<li>src/networkdialog.cpp <span style="color: grey">(9754cb9)</span></li>
<li>src/settingsbase.kcfgc <span style="color: grey">(f62547a)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109687/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>