<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109539/">http://git.reviewboard.kde.org/r/109539/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 19th, 2013, 3:05 a.m. UTC, <b>Parker Coates</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If we want to switch to a new scoring algorithm, there's a lot more to it than just changing the code calculating the score.
First we'd need a method of dealing with the old highscores. Do we just drop them? Do we try to convert them to the new system? Is that even possible. Leaving them in place is not an option as it's a completely apples-to-oranges ranking.
Second, we should try to future proof the highscore logic so that it doesn't need to be changed again later. The big one I can think of is sub-second accuracy. Whole seconds are a pretty big unit to work with when comparing times, especially on Easy difficulty.
Third, any changes need to be reflected in the documentation.
I'm not trying to be pessimistic or imply that it can't be done. It just isn't a change to be taken too lightly.</pre>
</blockquote>
<p>On March 20th, 2013, 3:35 p.m. UTC, <b>Ashwin Rajeev</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I know the problem is complicated that is why i asked other's opinion in mailing list. But it seems there are only few active members.
Is it possible to delete/change highscore by checking if it created with old method?</pre>
</blockquote>
<p>On March 21st, 2013, 9:38 p.m. UTC, <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Deleting the highscore is the least of your problems, you only need a kconfig entry to know if you've cleared them or not and to clear them just wipe out the underlying KConfig entries.
My concerns are various:
a) Is the new highscore algorithm really better
b) What if the user does *not* care about if the new highscore algorithm is better and he doesn't want to lose his highscores?</pre>
</blockquote>
<p>On March 22nd, 2013, 1:26 p.m. UTC, <b>Ashwin Rajeev</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">a) I believe this this algorithm is better than current one. But both algorithm doesn't consider the minimum moves required to complete the game. So i think i need to consideration this factor while calculating the highscore or restrict it within a certain range.
b) I don't have a solution to this issue. </pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">a) So you think its better but can still be better. Let's aim for that "still better" one, don't want to delete everyone highscores again next month no?
b) That's easy, ask them and keep the old code around (after all it's 2 lines)</pre>
<br />
<p>- Albert</p>
<br />
<p>On March 20th, 2013, 12:53 p.m. UTC, Ashwin Rajeev wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Games.</div>
<div>By Ashwin Rajeev.</div>
<p style="color: grey;"><i>Updated March 20, 2013, 12:53 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Let the score be time taken to complete in seconds, that also means one with less score gets on top.
Each penalty move will add 10 to score.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It may make problem with previously saved high scores.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=172089">172089</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/mainwindow.cpp <span style="color: grey">(dc437fe)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109539/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>