<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108234/">http://git.reviewboard.kde.org/r/108234/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 23rd, 2013, 11:25 p.m. UTC, <b>Christian Krippendorf</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks good to me and seem to work as it should. Well done!</pre>
</blockquote>
<p>On March 16th, 2013, 10:22 p.m. UTC, <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">So what is the status of this? Was it commited or still needs work?</pre>
</blockquote>
<p>On March 17th, 2013, 10 p.m. UTC, <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Jack, looks like this was never committed, I wonder why you put it against the qgraphic branch instead of the master one. Are you still interested in getting this commited? I guess master branch makes more sense if you want to have this in 4.11</pre>
</blockquote>
<p>On March 18th, 2013, 3:58 p.m. UTC, <b>Ian Simpson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I submitted this before creating an account with my real name.
The patch was for the qgraphic branch. As far as I can see, it's the only branch with the GameView class and the patch only applies there.
Christian was converting the game to use QGraphicsScene/View and was going to merge it into master but never got around to it before having to move on.</pre>
</blockquote>
<p>On March 18th, 2013, 7:20 p.m. UTC, <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">So I guess the question is, do you want to be the main driver behind qgraphic branch or should we should discard this review request?</pre>
</blockquote>
<p>On March 20th, 2013, 3:40 p.m. UTC, <b>Ian Simpson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Well, I'd be happy to work on it. I could at least try to get it ready to merge with master at some point. All the hard work has been done and it's pretty close to the current version. Just a few things to do I reckon.
Although Christian didn't commit this it looks like he thought it was ok, so I'd like to keep it.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hi there again, if you are planning to work on the qgraphic branch i suggest you to get an account and directly commit to it. Given that there is noone else working on the qgraphic branch and that it's not an "official" branch (i.e. it's not one of the release branches) I don't think it makes sense to review everything that goes in there. I think it's just easier if you work on the qgraphic branch to a point you think it's good enough and then we review it.
This might mean just killing all your review requests and you getting a git account. What do you (plural you) think?</pre>
<br />
<p>- Albert</p>
<br />
<p>On January 7th, 2013, 7:42 p.m. UTC, jack daniel wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Games.</div>
<div>By jack daniel.</div>
<p style="color: grey;"><i>Updated Jan. 7, 2013, 7:42 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Set up the KMahjongg::demoMode() slot to start and stop the demo mode.
Add a signal/slot to react to stopping the demo or MoveListAnimation with a mouse click.
Display a message box when demo mode is lost.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tried all variations of starting/stopping. Seems to work.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>GameView.h <span style="color: grey">(b3f3bda)</span></li>
<li>GameView.cpp <span style="color: grey">(d652ed6)</span></li>
<li>kmahjongg.h <span style="color: grey">(511126e)</span></li>
<li>kmahjongg.cpp <span style="color: grey">(d546732)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108234/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>