<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/7013/">http://svn.reviewboard.kde.org/r/7013/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 7th, 2012, 9:42 p.m., <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Do you have a sequence of actions that show the need for this if protection? i.e. what do i have to do so that the game crashes without this patch? Or is it all purely theorical?</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The call of GameView::gameOver inside GameView::startNewGame is reproducable.
1)setup a game with no human players the game must end without stopping to wait for input.
2)from the new game dialog quickly hit return, return, cntrl+N
You may have to do this few times to get the crash. The window of opportunity for this to happen is very small. It will most likely be GameView::gameOver that triggers the crash. I can provide a stack trace for this if needed as I can reliably reproduce GameView::gameOver inside GameView::startNewGame on unpatched code. GameView::startNewGame could theorically happpen as well thanks to these lines in localGame.cpp:
./localgame.cpp:34: qApp->processEvents(); // Really important : ignoring this will not apply the change soon enough
./localgame.cpp:43: qApp->processEvents(); // Really important : ignoring this will not apply the change soon enough
Oddly my stack trace now looks like the one in the bug but still only happens in unpatched code.</pre>
<br />
<p>- Michael</p>
<br />
<p>On August 6th, 2012, 7:05 p.m., Michael Reeves wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Games.</div>
<div>By Michael Reeves.</div>
<p style="color: grey;"><i>Updated Aug. 6, 2012, 7:05 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Attempt to fix crash due to null Map pointer. Prevents calling GameView::startNewGame or GameView::gameOver before GameView is fully ready the cause of my variant.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It fixes a related variant I was able to produce on my machine. I am unable to reproduce the bug as reported. Attempted to work around issue based on the stack traces alone.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=296290">296290</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/branches/KDE/4.8/kdegames/konquest/gameview.h <span style="color: grey">(1308596)</span></li>
<li>/branches/KDE/4.8/kdegames/konquest/gameview.cc <span style="color: grey">(1308596)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/7013/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>