<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/6951/">http://svn.reviewboard.kde.org/r/6951/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 29th, 2012, 2:33 p.m., <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://svn.reviewboard.kde.org/r/6951/diff/2/?file=47932#file47932line349" style="color: black; font-weight: bold; text-decoration: underline;">/trunk/KDE/kdegames/ksquares/src/ksquareswindow.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void KSquaresWindow::optionsPreferences()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">314</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span class="n">QWidget</span> <span class="o">*</span><span class="n">aiSettingsDialog</span> <span class="o">=</span> <span class="k">new</span> <span class="n">QWidget</span><span class="p">;</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">347</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="c1"><span class="hl">// </span><span class="tb"> </span>QWidget *aiSettingsDialog = new QWidget;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Why is this commented out?</pre>
</blockquote>
<p>On April 29th, 2012, 2:52 p.m., <b>Tom Vincent Peters</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I commented it out because you could "cheat" by playing the game against the easy ai, then changing it to hard in the last moment and thus get a highscore entry in the "hard" category.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">There are a few ways of handling this. Personally I prefer prompting the user when they change the difficulty *while a game is in progress* if they would like to abandon the current game and start a new one with the new difficulty.
If they say no, you can keep the current game as is and either revert the difficulty change or save the new difficulty and apply it to the next game. You can see Killbots for an example of the latter.</pre>
<br />
<p>- Parker</p>
<br />
<p>On April 29th, 2012, 7:51 p.m., Tom Vincent Peters wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Games and Matt Willliams.</div>
<div>By Tom Vincent Peters.</div>
<p style="color: grey;"><i>Updated April 29, 2012, 7:51 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hard AI for KSquares
Added per player AI difficulty
Moved AI settings from normal game to demo mode
Added player count parameter for demo mode
known unintentional changes to other AI:
medium AI probably will do hard-hearted handouts in most cases</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">100 autoplay games medium against hard
a lot of games against hard ai</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdegames/ksquares/ChangeLog <span style="color: grey">(1292133)</span></li>
<li>/trunk/KDE/kdegames/ksquares/src/aicontroller.h <span style="color: grey">(1292133)</span></li>
<li>/trunk/KDE/kdegames/ksquares/src/aicontroller.cpp <span style="color: grey">(1292133)</span></li>
<li>/trunk/KDE/kdegames/ksquares/src/gameboardscene.cpp <span style="color: grey">(1292133)</span></li>
<li>/trunk/KDE/kdegames/ksquares/src/ksquares.kcfg <span style="color: grey">(1292133)</span></li>
<li>/trunk/KDE/kdegames/ksquares/src/ksquaresdemowindow.h <span style="color: grey">(1292133)</span></li>
<li>/trunk/KDE/kdegames/ksquares/src/ksquaresdemowindow.cpp <span style="color: grey">(1292133)</span></li>
<li>/trunk/KDE/kdegames/ksquares/src/ksquareswindow.cpp <span style="color: grey">(1292133)</span></li>
<li>/trunk/KDE/kdegames/ksquares/src/main.cpp <span style="color: grey">(1292133)</span></li>
<li>/trunk/KDE/kdegames/ksquares/src/newgamewidget.ui <span style="color: grey">(1292133)</span></li>
<li>/trunk/KDE/kdegames/ksquares/src/prefs_ai.ui <span style="color: grey">(1292133)</span></li>
<li>/trunk/KDE/kdegames/ksquares/src/settings.kcfgc <span style="color: grey">(1292133)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/6951/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://svn.reviewboard.kde.org/r/6951/s/631/"><img src="http://svn.reviewboard.kde.org/media/uploaded/images/2012/04/29/ksquares0_400x100.png" style="border: 1px black solid;" alt="Hard AI move" /></a>
<a href="http://svn.reviewboard.kde.org/r/6951/s/632/"><img src="http://svn.reviewboard.kde.org/media/uploaded/images/2012/04/29/ksquares1_400x100.png" style="border: 1px black solid;" alt="New Game dialog" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>