<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/6931/">http://svn.reviewboard.kde.org/r/6931/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 6th, 2012, 1:31 p.m., <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://svn.reviewboard.kde.org/r/6931/diff/2/?file=47797#file47797line329" style="color: black; font-weight: bold; text-decoration: underline;">/trunk/KDE/kdegames/kiriki/src/kiriki.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void kiriki::showPreferences()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">328</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span class="tb"> </span> <span class="n">m_scores</span><span class="o">-></span><span class="n">redraw</span><span class="p">(</span><span class="n">m_scores</span><span class="o">-></span><span class="n">index</span><span class="p">(</span><span class="n">i</span><span class="p">,</span><span class="mi">0</span><span class="p">));</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">No need to iterate over the rows, just have a redraw and then in the redraw funcion use the two parameters to specify that the whole table needs to be redrawn.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I saw in the Qt Documentation that if the two parameters to dataChanged() are the same then it redraws the entire table but in the redraw function when I tried emit dataChanged(mi,mi) it was not working. Is this approach correct?</pre>
<br />
<p>- Arjun</p>
<br />
<p>On April 6th, 2012, 1:13 p.m., Arjun Basu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Games.</div>
<div>By Arjun Basu.</div>
<p style="color: grey;"><i>Updated April 6, 2012, 1:13 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is in response to the feature request https://bugs.kde.org/show_bug.cgi?id=225582. Now, there is a provision of increasing the font size and as a result the row height increases too. The value of the font size in the preferences can take values from 0 to 10. O being the default font size.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I have tested it and it works fine</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdegames/kiriki/src/configPage.ui <span style="color: grey">(1282954)</span></li>
<li>/trunk/KDE/kdegames/kiriki/src/kiriki.cpp <span style="color: grey">(1282954)</span></li>
<li>/trunk/KDE/kdegames/kiriki/src/kiriki.kcfg <span style="color: grey">(1282954)</span></li>
<li>/trunk/KDE/kdegames/kiriki/src/row.h <span style="color: grey">(1282954)</span></li>
<li>/trunk/KDE/kdegames/kiriki/src/scores.h <span style="color: grey">(1282954)</span></li>
<li>/trunk/KDE/kdegames/kiriki/src/scores.cpp <span style="color: grey">(1282954)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/6931/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://svn.reviewboard.kde.org/r/6931/s/629/"><img src="http://svn.reviewboard.kde.org/media/uploaded/images/2012/03/31/PreferencesDialog_400x100.jpeg" style="border: 1px black solid;" alt="The New Preferences Dialog" /></a>
<a href="http://svn.reviewboard.kde.org/r/6931/s/630/"><img src="http://svn.reviewboard.kde.org/media/uploaded/images/2012/03/31/Canvas_400x100.jpeg" style="border: 1px black solid;" alt="The Game Canvas after increasing font size" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>