<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/6908/">http://svn.reviewboard.kde.org/r/6908/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Would you mind splitting this into two patches? One to port to QGraphicsScene and one porting to KgSound? We typically like to see smaller, focused patches as they're easier to review.</pre>
<br />
<p>- Parker</p>
<br />
<p>On March 12th, 2012, 3:55 p.m., Mehmet Emre wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Games.</div>
<div>By Mehmet Emre.</div>
<p style="color: grey;"><i>Updated March 12, 2012, 3:55 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I've ported bomber to QGraphicsView as requested here: http://techbase.kde.org/Projects/Games/Porting. I've made some modifications on the classes below:
- Explodable
- BomberBoard
- BomberGameWidget
- Building</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I've done these tests and solved the problems that I've bumped into:
- Played bomber's first two levels.
- Paused the game
- Changed settings during the game and while game is paused.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/KDE/kdegames/bomber/src/board.h <span style="color: grey">(1284898)</span></li>
<li>trunk/KDE/kdegames/bomber/src/board.cpp <span style="color: grey">(1284898)</span></li>
<li>trunk/KDE/kdegames/bomber/src/bomberwidget.h <span style="color: grey">(1284898)</span></li>
<li>trunk/KDE/kdegames/bomber/src/bomberwidget.cpp <span style="color: grey">(1284898)</span></li>
<li>trunk/KDE/kdegames/bomber/src/building.h <span style="color: grey">(1284898)</span></li>
<li>trunk/KDE/kdegames/bomber/src/building.cpp <span style="color: grey">(1284898)</span></li>
<li>trunk/KDE/kdegames/bomber/src/explodable.h <span style="color: grey">(1284898)</span></li>
<li>trunk/KDE/kdegames/bomber/src/explodable.cpp <span style="color: grey">(1284898)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/6908/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>