<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/6902/">http://svn.reviewboard.kde.org/r/6902/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 13th, 2012, 11:24 p.m., <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://svn.reviewboard.kde.org/r/6902/diff/1/?file=47623#file47623line103" style="color: black; font-weight: bold; text-decoration: underline;">trunk/KDE/kdegames/libkdegames/audio/kgaudioscene-openal.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void KgOpenALRuntime::configureListener()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">103</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span class="tb"> </span><span class="n">kDebug</span><span class="p">()</span> <span class="o"><<</span> <span class="s">"Failed to setup OpenAL listener: Error code"</span> <span class="o"><<</span> <span class="n">error</span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">As a developer using KGSound i'd like to get a way to get this and the other errors of this class up</pre>
</blockquote>
<p>On February 15th, 2012, 12:05 a.m., <b>Stefan Majewsky</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I doubt it's worth the effort. I don't expect the OpenAL calls to fail in any sane environment, they're just there for completeness. And even if it fails... KgAudio targets games where the sound effects are not mission-critical, i.e. the game won't be completely unplayable without sounds. If the sound won't work, what are you going to do?
I don't see any need to do any error analysis that's more detailed than kDebug(). If anybody wants an API for error retrieval, it can easily be added to KgSound later.</pre>
</blockquote>
<p>On February 15th, 2012, 2:35 a.m., <b>Parker Coates</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">At the very least, I think you should upgrade the kDebug()s to kWarning()s.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Parker has a point. I changed that before commiting.</pre>
<br />
<p>- Stefan</p>
<br />
<p>On February 15th, 2012, 12:34 a.m., Stefan Majewsky wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Games and Ian Wadham.</div>
<div>By Stefan Majewsky.</div>
<p style="color: grey;"><i>Updated Feb. 15, 2012, 12:34 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">As the first new component in libkdegames v5, I'm adding TagaroAudio which has already resided in the kdegames source tree via private static copies in Granatier and KGoldRunner. This patch ports both to the new classes in libkdegames.
Because the Tagaro brand name need be eliminated as the code is imported into libkdegames, I have removed the Tagaro namespace and added a "Kg" prefix to the class names, which are now KgAudioScene and KgSound. I know that this is a departure from the current "KGameFoo" naming scheme, see my mail to the kde-games-devel@ about this.
I could not get reviewboard to accept my patch including the various files I deleted, so here's a list of all deleted stuff:
* granatier/cmake/modules/FindSndFile.cmake (now in <toplevel>/cmake/modules)
* granatier/src/TagaroAudio
* granatier/src/granatiersound.{h,cpp} (Tagaro::Sound is now used directly instead of the thin wrapper GranatierSound)
* kgoldrunner/cmake/modules/FindSndFile.cmake (see above; why did we have two copies of this anyway?)
* kgoldrunner/src/TagaroAudio
* kgoldrunner/src/kgrsoundbank.{h,cpp} (after I removed the ifdefs, it was not used anywhere, so I figured it's about time to retire this class).
I checked the log of the static copies of TagaroAudio in Granatier and KGoldRunner, and imported a patch from Mathias Kraus in granatier/src/Tagaro into the KgAudio code.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Sound playback works in Granatier and KGoldRunner.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/KDE/kdegames/CMakeLists.txt <span style="color: grey">(1279940)</span></li>
<li>trunk/KDE/kdegames/cmake/modules/FindSndFile.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdegames/granatier/CMakeLists.txt <span style="color: grey">(1279940)</span></li>
<li>trunk/KDE/kdegames/granatier/src/CMakeLists.txt <span style="color: grey">(1279940)</span></li>
<li>trunk/KDE/kdegames/granatier/src/game.h <span style="color: grey">(1279940)</span></li>
<li>trunk/KDE/kdegames/granatier/src/game.cpp <span style="color: grey">(1279940)</span></li>
<li>trunk/KDE/kdegames/kgoldrunner/CMakeLists.txt <span style="color: grey">(1279940)</span></li>
<li>trunk/KDE/kdegames/kgoldrunner/src/CMakeLists.txt <span style="color: grey">(1279940)</span></li>
<li>trunk/KDE/kdegames/kgoldrunner/src/kgoldrunner.cpp <span style="color: grey">(1279940)</span></li>
<li>trunk/KDE/kdegames/kgoldrunner/src/kgrgame.h <span style="color: grey">(1279940)</span></li>
<li>trunk/KDE/kdegames/kgoldrunner/src/kgrgame.cpp <span style="color: grey">(1279940)</span></li>
<li>trunk/KDE/kdegames/kgoldrunner/src/kgrsounds.h <span style="color: grey">(1279940)</span></li>
<li>trunk/KDE/kdegames/kgoldrunner/src/kgrsounds.cpp <span style="color: grey">(1279940)</span></li>
<li>trunk/KDE/kdegames/kgoldrunner/src/main.cpp <span style="color: grey">(1279940)</span></li>
<li>trunk/KDE/kdegames/libkdegames/CMakeLists.txt <span style="color: grey">(1279940)</span></li>
<li>trunk/KDE/kdegames/libkdegames/audio/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdegames/libkdegames/audio/check-libsndfile-capabilities.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdegames/libkdegames/audio/kgaudioscene-openal.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdegames/libkdegames/audio/kgaudioscene-phonon.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdegames/libkdegames/audio/kgaudioscene.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdegames/libkdegames/audio/kgopenalruntime_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdegames/libkdegames/audio/kgsound-openal.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdegames/libkdegames/audio/kgsound-phonon.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdegames/libkdegames/audio/kgsound.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdegames/libkdegames/includes/CMakeLists.txt <span style="color: grey">(1279940)</span></li>
<li>trunk/KDE/kdegames/libkdegames/includes/KgAudioScene <span style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdegames/libkdegames/includes/KgSound <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/6902/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>