<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/6841/">http://svn.reviewboard.kde.org/r/6841/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On December 14th, 2011, 1:36 p.m., <b>Frederik Schwarzer</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://svn.reviewboard.kde.org/r/6841/diff/2/?file=47251#file47251line404" style="color: black; font-weight: bold; text-decoration: underline;">trunk/KDE/kdegames/kmahjongg/boardwidget.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void BoardWidget::gameLoaded()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">404</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">setStatusText</span><span class="p">(</span><span class="n">i18n</span><span class="p">(</span><span class="s">"No undo allowed, your game has finished!"</span><span class="p">));</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hmm, I am not very happy with the message. What about: "You have finished this board, there is nothing to be undone"?
Maybe a native speaker could give advice here.</pre>
</blockquote>
<p>On December 14th, 2011, 9:32 p.m., <b>Ian Wadham</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">How about "Cannot undo: you have finished this puzzle."?
Both of the previous suggestions would be good English, but "No undo allowed" is a little impolite and "game" gets us into that "What is a game?" argument. Is it just the puzzle you are on or is it the whole KMahjongg session? English tends to be ambiguous.</pre>
</blockquote>
<p>On December 14th, 2011, 11:18 p.m., <b>Christian Krippendorf</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I don't think so realted to "game". In KMahjongg i can choose a new game on "Game" -> "New" und also a special "Game number" so i think that "game" isn't that bad. I would prefer "game" rather than "puzzle".
"Cannot undo: you have finished this game." <- That sounds good to me.</pre>
</blockquote>
<p>On December 15th, 2011, 6:46 a.m., <b>Ian Wadham</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">OK. Coder decides.</pre>
</blockquote>
<p>On January 4th, 2012, 4:58 p.m., <b>Christian Krippendorf</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Finally code ok for commiting?</pre>
</blockquote>
<p>On January 4th, 2012, 6:44 p.m., <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Wondering if it would be better just disabling the undo action?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Umm, right. I agree here. In KShisen I do it like that.
void App::updateItems()
{
if (m_board->isOver()) {
actionCollection()->action(KStandardGameAction::name(KStandardGameAction::Undo))->setEnabled(false);
actionCollection()->action(KStandardGameAction::name(KStandardGameAction::Redo))->setEnabled(false);
actionCollection()->action(KStandardGameAction::name(KStandardGameAction::Pause))->setEnabled(false);
actionCollection()->action(KStandardGameAction::name(KStandardGameAction::Hint))->setEnabled(false);
} else if (m_board->isPaused()) {
actionCollection()->action(KStandardGameAction::name(KStandardGameAction::Undo))->setEnabled(false);
actionCollection()->action(KStandardGameAction::name(KStandardGameAction::Redo))->setEnabled(false);
actionCollection()->action(KStandardGameAction::name(KStandardGameAction::Restart))->setEnabled(false);
actionCollection()->action(KStandardGameAction::name(KStandardGameAction::Pause))->setChecked(true);
actionCollection()->action(KStandardGameAction::name(KStandardGameAction::Hint))->setEnabled(false);
} else if (m_board->isStuck()) {
actionCollection()->action(KStandardGameAction::name(KStandardGameAction::Pause))->setEnabled(false);
actionCollection()->action(KStandardGameAction::name(KStandardGameAction::Hint))->setEnabled(false);
} else {
actionCollection()->action(KStandardGameAction::name(KStandardGameAction::Undo))->setEnabled(m_board->canUndo());
actionCollection()->action(KStandardGameAction::name(KStandardGameAction::Redo))->setEnabled(m_board->canRedo());
actionCollection()->action(KStandardGameAction::name(KStandardGameAction::Restart))->setEnabled(m_board->canUndo());
actionCollection()->action(KStandardGameAction::name(KStandardGameAction::Pause))->setEnabled(true);
actionCollection()->action(KStandardGameAction::name(KStandardGameAction::Pause))->setChecked(false);
actionCollection()->action(KStandardGameAction::name(KStandardGameAction::Hint))->setEnabled(true);
}
}
</pre>
<br />
<p>- Frederik</p>
<br />
<p>On December 28th, 2011, 6:56 p.m., Christian Krippendorf wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Games.</div>
<div>By Christian Krippendorf.</div>
<p style="color: grey;"><i>Updated Dec. 28, 2011, 6:56 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Bug List Link: https://bugs.kde.org/show_bug.cgi?id=215352</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/KDE/kdegames/kmahjongg/boardwidget.cpp <span style="color: grey">(1270752)</span></li>
<li>trunk/KDE/kdegames/kmahjongg/kmahjongg.cpp <span style="color: grey">(1270752)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/6841/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>